Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change oracle production docker context #66

Merged
merged 8 commits into from
May 23, 2019
Merged

Change oracle production docker context #66

merged 8 commits into from
May 23, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented May 23, 2019

Change context of oracle production docker image from sub-directory to root-directory.

Pros

Cons

  • The yarn install downloads and installs node_modules for every sub-dir which is more than the oracle needs
    • yarn install --production skips devDependencies to mitigate this
    • Moving as much as possible into devDependencies in Clean up dependencies #46 will mitigate this further

@rzadp rzadp added the oracle related to TokenBridge oracle label May 23, 2019
@rzadp rzadp mentioned this pull request May 23, 2019
Merged
@rzadp rzadp requested review from akolotov and patitonar May 23, 2019 12:55
@rzadp rzadp marked this pull request as ready for review May 23, 2019 13:22
@akolotov akolotov changed the title [WIP] Change oracle production docker context Change oracle production docker context May 23, 2019
@akolotov akolotov merged commit 7a1ce41 into master May 23, 2019
@akolotov akolotov deleted the docker-package-lock branch May 24, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

@patitonar patitonar Awaiting requested review from patitonar

Assignees
No one assigned
Labels
oracle related to TokenBridge oracle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on package-lock.json in Dockerfiles
2 participants
@rzadp @akolotov