Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract repeated submodules/poa-bridge-contracts into one in root dir #21

Closed
rzadp opened this issue May 7, 2019 · 3 comments · Fixed by #71
Closed

Extract repeated submodules/poa-bridge-contracts into one in root dir #21

rzadp opened this issue May 7, 2019 · 3 comments · Fixed by #71
Labels
e2e related to end to end testing oracle related to TokenBridge oracle shared shared components UI related to TokenBridge UI

Comments

@rzadp
Copy link
Contributor

rzadp commented May 7, 2019 •
edited
Loading

Release 2.3.0-rc0 should be used for poa-bridge-contracts.
@rzadp rzadp added the shared shared components label May 7, 2019
@akolotov
Copy link
Collaborator

akolotov commented May 7, 2019 •
edited by rzadp
Loading

  • I would add even more - instead of usage of ABI sourced in the token-bridge/abis oracle/abis directory it is necessary to compile them from the contract submodule. By doing this we will always have updated ABIs without necessity to update them manually every time when the contracts are being changed.

This was referenced May 7, 2019
Closed
Closed
@akolotov
Copy link
Collaborator

akolotov commented May 9, 2019 •
edited by rzadp
Loading

In order to not mix the work let's consider this issue to

  • introduce the git submodule for the bridge contracts in the root dir
  • change the oracle and UI projects as so this submodule is used for e2e tests (this is only the place where the contract submodule is used now).

@akolotov akolotov added e2e related to end to end testing oracle related to TokenBridge oracle UI related to TokenBridge UI labels May 9, 2019
@rzadp rzadp mentioned this issue May 15, 2019
Merged
@rzadp
Copy link
Contributor Author

rzadp commented May 21, 2019

Fully finishing this is blocked on #52 and #53

This was referenced May 21, 2019
Merged
Merged
Merged
Closed
Merged
@rzadp rzadp closed this as completed in #71 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e2e related to end to end testing oracle related to TokenBridge oracle shared shared components UI related to TokenBridge UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Oracle & Monitor - Compiled ABI's omni/tokenbridge
2 participants
@rzadp @akolotov