-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sub-dockerfiles and sub-contracts #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patitonar please take a look as well
@patitonar do you have understanding why the e2e on UI side does not work with the contracts |
I didn't spend time to look into this yesterday as I wanted to roll out the PR for review sooner. Maybe I'll be able to figure this out today. |
I think I found the difference. The following must be updated in
After that the contracts |
Some of these variables probably need to be added in some on the env files and some on others env files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove duplicated DEPLOYMENT_GAS_LIMIT
parameter in the files located in ui-e2e/envs
@patitonar could you check one more time and approve the PR? thanks! |
Purpose
The purpose of this PR is to:
package-lock.json
and get rid of excessiveDockerfiles
as per Remove dependency onpackage-lock.json
in Dockerfiles #44contracts
in root directory instead of nested submodules andgit clones
in sub-Dockerfiles as per Extract repeated submodules/poa-bridge-contracts into one in root dir #21Achieved work
oracle-e2e
andui-e2e
share parity config in root directoryoracle-e2e
uses contracts in root directoryui-e2e
uses contracts in root directoryDockerfiles
ui-e2e
work on CI - closes Extract bridge-ui/e2e and configure CircleCI #6Contracts issues
contracts/package.json
is installed by yarn and included in yarn workspaces, butcontracts/deploy/package.json
is installed separately by npmpackage.json's
contracts-2.1.0
andbecausecontracts-2.2.0
oracle-e2e
andui-e2e
were hardcoded to use these tags and do not work with ourcontracts
at2.3.0-rc0
contracts-*
and Extract repeated submodules/poa-bridge-contracts into one in root dir #21 can be completely finishedpoa-parity-bridge-contracts
, so the excessive sub-folders are handled by npm