Remove dependency on package-lock.json in Dockerfiles

[rzadp]

The Dockerfiles are COPYing package-lock.json when building images.
We should remove this dependency, or rely on yarn.lock instead.

[rzadp]

Dependencies problem

The Docker build processes rely on sub-repository package.lock and package-lock.jsonwhen installing dependencies.

Our local build process installs dependencies for all sub-repositories at one time, and uses one yarn.lock in root directory.

We shouldn't have different methods of installing dependencies locally and when building docker images because it can cause tricky errors.

Number of Dockerfiles

There is a total of 7 Dockerfiles, plus one in poa-bridge-contracts.

Seems excessive and increases complexity.

Proposed solution

I'm thinking about having one Dockerfile in root directory. It would install dependencies for sub-repositories using main yarn.lock, and would be used as a build base for sub-repositories docker-compose files.

@akolotov @phahulin @ArseniiPetrovich Do you have any comments on this?

[akolotov]

@patitonar could you take a look and provide your thoughts?

[akolotov]

My understanding is that some of these docker files are used for e2e testing only, whereas others are to build images used in production. @patitonar please correct me if I am wrong.

So probably we will need to differentiate different docker files for different purposes in the final solution anyway.

[patitonar]

We shouldn't have different methods of installing dependencies locally and when building docker images because it can cause tricky errors.

I agree on this, we should use yarn only.

Regarding the Dockerfile most of them are use for e2e testing and can be replaced by accessing the sub-repository needed or be unified in the case of the repeated Parity nodes Dockerfile used on e2e tests. I think the only one used for build for production along with the docker-compose file are the one from the oracle sub-repository