Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bridge contracts as git submodule #33

Closed
patitonar opened this issue Sep 5, 2018 · 4 comments
Closed

Add bridge contracts as git submodule #33

patitonar opened this issue Sep 5, 2018 · 4 comments
Labels
enhancement New feature or request monitor related to TokenBridge monitor oracle related to TokenBridge oracle UI related to TokenBridge UI

Comments

@patitonar
Copy link
Contributor

Add poa-bridge-contracts (branch refactor_v1) repository as a git submodule and use compiled contracts instead of contracts on abis directory
@akolotov akolotov transferred this issue from omni/bridge-monitor May 8, 2019
@akolotov akolotov added monitor related to TokenBridge monitor enhancement New feature or request labels May 8, 2019
@rzadp
Copy link
Contributor

rzadp commented May 9, 2019

Is it not a duplicate of #21 ?
Also I cannot seem to find refactor_v1 in poa-bridge-contracts.
Should we not use 2.3.0-rc0 tag?

@akolotov
Copy link
Collaborator

akolotov commented May 9, 2019

Correct. I specified in #21 a list of work that needs to be done there as per the approach you are suggesting to follow: small set of changes for one issue.

@akolotov
Copy link
Collaborator

akolotov commented May 9, 2019

Let's consider this issue to introduce compilation of the contracts in the process of installing dependencies.

  • use ABIs of installed contracts in the oracle instead of pre-compiled ABIs.
  • use ABIs of installed contracts in the UI instead of pre-compiled ABIs.
  • use ABIs of installed contracts in the monitor instead of pre-compiled ABIs.

The most actual version of contracts should be used at the moment when this issue is assigned for implementation.

@akolotov akolotov added oracle related to TokenBridge oracle UI related to TokenBridge UI labels May 9, 2019
@rzadp
Copy link
Contributor

rzadp commented May 28, 2019

This was done in #21

@rzadp rzadp closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request monitor related to TokenBridge monitor oracle related to TokenBridge oracle UI related to TokenBridge UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patitonar @rzadp @akolotov