Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dotfiles #61

Merged
merged 13 commits into from
May 23, 2019
Merged

Merge dotfiles #61

merged 13 commits into from
May 23, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented May 22, 2019 •
edited
Loading

Merged / Moved to root dir:

  • .gitignore
  • .editorconfig
  • .nvmrc
    • I chose 10.15 in order to follow .nvmrc in the contracts
  • .dockerignore

Removed:

  • .nycrc as nyc is not used

I think it closes #20

@rzadp rzadp added the shared shared components label May 22, 2019
@rzadp rzadp requested review from akolotov and patitonar May 22, 2019 15:15
@rzadp rzadp marked this pull request as ready for review May 22, 2019 15:15
akolotov
akolotov reviewed May 22, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should oracle/.dockerignore be used by oracle/Dockerfile when the oracle image is built for production?

@rzadp
Copy link
Contributor Author

rzadp commented May 23, 2019

Should oracle/.dockerignore be used by oracle/Dockerfile when the oracle image is built for production?

Good call, I have duplicated the .dockerignore so now we have 2 Dockerfile's and 2 corresponding .dockerignore's

akolotov
akolotov reviewed May 23, 2019
View reviewed changes
.dockerignore Outdated Show resolved Hide resolved
@akolotov akolotov merged commit d98073b into master May 23, 2019
@akolotov akolotov deleted the dotfiles branch May 23, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

@patitonar patitonar Awaiting requested review from patitonar

Assignees
No one assigned
Labels
shared shared components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge individual dotfiles into one
2 participants
@rzadp @akolotov