Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pin Node version in package.json #106

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Do not pin Node version in package.json #106

merged 10 commits into from
Sep 20, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Sep 19, 2023 •
edited
Loading

Refs: MaibornWolff/codecharta#3362 (comment)

The PR linked above fails since engine-strict is set to true. Did not take this into account when I hardcoded the Node version.

Changes

  • Do not pin Node dependency
  • Allow installing NW.js on LTS Node version (get Node version from https://nwjs.io/versions instead)

cc @TheJaredWilcurt

@ayushmanchhabra ayushmanchhabra changed the title fix: do not pin Node version in package.json Do not pin Node version in package.json Sep 19, 2023
@ayushmanchhabra ayushmanchhabra marked this pull request as draft September 19, 2023 16:23
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review September 19, 2023 18:50
@TheJaredWilcurt TheJaredWilcurt merged commit 8f6ac34 into nwjs:master Sep 20, 2023
1 check passed
@ayushmanchhabra ayushmanchhabra deleted the fix/node-version branch September 20, 2023 03:19
@ayushmanchhabra ayushmanchhabra mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJaredWilcurt TheJaredWilcurt TheJaredWilcurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushmanchhabra @TheJaredWilcurt