Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inappropriate Required Node & NPM Version #109

Closed
ronny1982 opened this issue Sep 24, 2023 · 4 comments · Fixed by #114
Closed

Inappropriate Required Node & NPM Version #109

ronny1982 opened this issue Sep 24, 2023 · 4 comments · Fixed by #114

Comments

@ronny1982
Copy link

ronny1982 commented Sep 24, 2023 •
edited
Loading

The latest changes introduce a forced minimum version of Node and NPM in the package.json.
This version is then used for the CI pipeline to configure the Node/NPM version.

Production code should not contain configurations for the automated test pipeline. Now all developers are forced to use a non-LTS Node/NPM version.

I suggest to either remove the required versions from the package.json and facilitate matrix builds in the CI pipeline with whatever Node/NPM versions, or require an appropriate (minimum) version in package.json and not the latest and greatest Node/NPM version. I'm pretty sure this package is even compatible when run with Node v16 LTS.
@ronny1982
Copy link
Author

See also: #96

@ronny1982 ronny1982 changed the title Required Node & NPM Version Inappropriate Required Node & NPM Version Sep 24, 2023
@ronny1982
Copy link
Author

Workaround:
A project that uses nw must ensure not using engine-strict = true, so it only shows up as warning and not as error when installing the nw package dependency.

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Oct 2, 2023 •
edited
Loading

@ronny1982 Realised my mistake and fixed in #106. It should work with v0.81.x onwards. You can patch the current release or unset engine-strict, as you've said above.

@ayushmanchhabra ayushmanchhabra mentioned this issue Oct 3, 2023
Merged
TheJaredWilcurt pushed a commit that referenced this issue Oct 7, 2023
@ayushmanchhabra
Refactor install script (#114)
86b52bc 
* Refactor install script:
  * Convert from CJS to ESM
  * Improve code documentation
  * Adopt many ES6+ coding styles (let/const, promises, optional chaining, endsWith, etc.)
* Manifest Maintenance:
  * Reduce dependencies from 10 to 5 by swapping most out for native Node modules, or newer alternatives.
  * Updated dependencies.
  * Remove "engines" and "packageManager" from manifest to avoid reported issues.
* Bug fixes:
  * #26 & #74 - Freezing during or after post-install step.
  * #77 - Decompress API change bug. Swapped Decompress for Compressing.
  * #93 - Errors on install and deprecation warnings
  * #109 - Engines/packageManager mismatch
@tjmoore
Copy link

tjmoore commented Oct 20, 2023 •
edited
Loading

@ronny1982 Realised my mistake and fixed in #106. It should work with v0.81.x onwards. You can patch the current release or unset engine-strict, as you've said above.

I'm using yarn and adding with yarn add nw and I get this with Node LTS, with 0.81.0

error [email protected]: The engine "node" is incompatible with this module. Expected version "v20.5.0". Got "18.18.2"
error Found incompatible module.

and latest node 20 (using nvm use 20), still insists on specific version.

error [email protected]: The engine "node" is incompatible with this module. Expected version "v20.5.0". Got "20.8.1"
error Found incompatible module.

workaround - yarn add nw --ignore-engines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor install script
3 participants
@tjmoore @ayushmanchhabra @ronny1982