Skip to content

Commit

Permalink
Do not pin Node version in package.json (#106)
Browse files Browse the repository at this point in the history
* build(npm): update to v10.1.0

* build(dependabot): batch updates

* ci: use latest Node version

* chore: revert some changes

* fix: do not pin node version

* chore: revert batch update

* build(node): allow LTS

* fix(ci): checkout repo before parsing Node version

* fix(ci: remove duplicate setup node step

* fix(ci): get Node version from manifest
  • Loading branch information
ayushmanchhabra authored Sep 20, 2023
1 parent 7998478 commit 8f6ac34
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ updates:
schedule:
interval: "daily"
- package-ecosystem: "github-actions"
directory: ".github/"
directory: ".github/workflows"
schedule:
interval: "daily"
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ jobs:
test:
runs-on: ubuntu-22.04
steps:
- uses: actions/[email protected]
- name: Checkout repository
uses: actions/[email protected]
- name: Get Node version from Node manifest
run: |
echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV
- uses: actions/[email protected]
run: echo "NODE_VER=$(curl -s https://nwjs.io/versions | jq -r ".versions[0].components.node")" >> $GITHUB_ENV
- name: Setup Node
uses: actions/[email protected]
with:
node-version: ${{ env.NODE_VER }}
cache: "npm"
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
"request": "^2.53.0"
},
"engines": {
"node": "v20.5.0"
"node": ">= 20.5.0 || >= 18.18.0"
},
"packageManager": "npm@9.8.1",
"packageManager": "npm@10.1.0",
"keywords": [
"nw",
"nw.js",
Expand Down

0 comments on commit 8f6ac34

Please sign in to comment.