Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pin Node version in package.json #106

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Do not pin Node version in package.json #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cec1bca
build(npm): update to v10.1.0
ayushmanchhabra Sep 19, 2023
e8cbd1c
build(dependabot): batch updates
ayushmanchhabra Sep 19, 2023
d8bc468
ci: use latest Node version
ayushmanchhabra Sep 19, 2023
c63e6fa
chore: revert some changes
ayushmanchhabra Sep 19, 2023
6302248
fix: do not pin node version
ayushmanchhabra Sep 19, 2023
6f2bb92
chore: revert batch update
ayushmanchhabra Sep 19, 2023
c9ddc23
build(node): allow LTS
ayushmanchhabra Sep 19, 2023
3a47e9d
fix(ci): checkout repo before parsing Node version
ayushmanchhabra Sep 19, 2023
11b6aea
fix(ci: remove duplicate setup node step
ayushmanchhabra Sep 19, 2023
27c42be
fix(ci): get Node version from manifest
ayushmanchhabra Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ updates:
schedule:
interval: "daily"
- package-ecosystem: "github-actions"
directory: ".github/"
directory: ".github/workflows"
schedule:
interval: "daily"
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ jobs:
test:
runs-on: ubuntu-22.04
steps:
- uses: actions/[email protected]
- name: Checkout repository
uses: actions/[email protected]
- name: Get Node version from Node manifest
run: |
echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV
- uses: actions/[email protected]
run: echo "NODE_VER=$(curl -s https://nwjs.io/versions | jq -r ".versions[0].components.node")" >> $GITHUB_ENV
- name: Setup Node
uses: actions/[email protected]
with:
node-version: ${{ env.NODE_VER }}
cache: "npm"
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
"request": "^2.53.0"
},
"engines": {
"node": "v20.5.0"
"node": ">= 20.5.0 || >= 18.18.0"
},
"packageManager": "npm@9.8.1",
"packageManager": "npm@10.1.0",
"keywords": [
"nw",
"nw.js",
Expand Down