-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v14.6.0 proposal #34371
v14.6.0 proposal #34371
Conversation
Backport-PR-URL: #33961 PR-URL: #33889 Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings Refs: https://docs.microsoft.com/en-us/style-guide/capitalization Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
2e91d52
to
bd208a9
Compare
Pushing the release until tomorrow so we can try and land v8 8.4 (backport pr) |
bd208a9
to
6629373
Compare
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) #34246 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) #34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) #34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 PR-URL: #34371
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) #34246 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](#33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) #34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) #34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 PR-URL: #34371
6629373
to
93694f6
Compare
There are legitimate CITGM failures happening 😅 Bisecting right now, but we might have to delay the release further, in which case I might punt to next week (to avoid releasing Friday). |
When `util.inspect()` is called on an object with a custom inspect function, and that object is from a different `vm.Context`, that function will not receive any arguments that access context-specific data anymore. PR-URL: #33690 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Document that it is not necessary to open handle and/or callback scopes inside finalizer, async work, thread-safe function etc. callbacks unless for reasons documented in the section about object lifetime management. Link usage of callback signatures to their definition. Fixes: #33893 PR-URL: #33915 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #33983 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #33977 PR-URL: #33996 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
This allows timeouts to apply to e.g. `Promise`s and `async function`s from code running inside of `vm.Context`s, by giving the Context its own microtasks queue. Fixes: #3020 PR-URL: #34023 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
PR-URL: #33832 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Edit for clarity, correct tense, and brevity. PR-URL: #34064 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Use shorter and more direct phrasing. PR-URL: #34063 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
PR-URL: #34072 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@addaleax fixed |
This ensures that microtasks scheduled by native immediates are run after the tasks are done. In particular, this affects the inspector integration since 6f9f546. Fixes: #33002 Refs: #32523 PR-URL: #34366 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) #34246 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](#33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) #34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) #34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 PR-URL: #34371
7999aa2
to
ca62c34
Compare
One more CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2433/ |
This reverts commit 673f49a. This change is breaking gulp on v14.x. Reverting so we can reland in a way that doesn't break stuff Refs: nodejs#33660 Refs: nodejs#34371
We have a green CI! There are failures in CITGM, but none that are new in 14.6.0. We may want to revert some thing or make changes moving forward, but I'm going to go ahead and promote this release at this point so we can get started on working on 14.7.0 |
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) #34246 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](#33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) #34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) #34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 PR-URL: #34371
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) #34246 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](#33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) #34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) #34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 PR-URL: #34371
2020-07-21, Version 14.6.0 (Current), @MylesBorins
Notable Changes
Commits
afec0d7f51
] - async_hooks: improve resource stack performance (Anna Henningsen) #34319f340571301
] - (SEMVER-MINOR) build: reset embedder string to "-node.0" (Michaël Zasso) #33579de250c136c
] - build: recommend Python 3.8 to build on Windows (Michaël Zasso) #34182a130771d4f
] - build,tools: fix cmd_regen_makefile (Daniel Bevenius) #34255cfd4c8012d
] - crypto: move typechecking for timingSafeEqual into C++ (Anna Henningsen) #3414195afc2e50e
] - deps: V8: update headers for ABI compatibility (Anna Henningsen) #343562c9fd6ebd4
] - deps: V8: revert de4c0042cbe6 from upstream V8 (Anna Henningsen) #34356447b1e86a5
] - deps: V8: re-add dummy Isolate::CheckMemoryPressure (Anna Henningsen) #343562079fefacf
] - deps: V8: undo header change of 9dbab9bbdb979 (Anna Henningsen) #343569f886c968c
] - (SEMVER-MINOR) deps: bump minimum icu version to 67 (Michaël Zasso) #335793fa7ad3375
] - (SEMVER-MINOR) deps: update V8 postmortem metadata script (Colin Ihrig) #335794c37837424
] - deps: V8: cherry-pick eec10a2fd8fa (Stephen Belanger) #33778fb180ac110
] - deps: V8: backport 22014de00115 (Joyee Cheung) #3330001e788622c
] - (SEMVER-MINOR) deps: V8: fix compilation on VS2017 (Jiawen Geng) #33579f269dff06e
] - (SEMVER-MINOR) deps: V8: cherry-pick 9868b2aefa1a (Michaël Zasso) #33579335e3861c3
] - (SEMVER-MINOR) deps: patch V8 to run on Xcode 8 (Matheus Marchini) #32116355e2f2b6a
] - (SEMVER-MINOR) deps: V8: silence irrelevant warnings (Michaël Zasso) #32116eb6ded61b7
] - (SEMVER-MINOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32116a4b71e02ca
] - (SEMVER-MINOR) deps: V8: forward declaration ofRtl\*FunctionTable
(Refael Ackermann) #321161e37442fdd
] - (SEMVER-MINOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32116eac35c6061
] - (SEMVER-MINOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #3211651d86f4b59
] - (SEMVER-MINOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #321169cd523d148
] - (SEMVER-MINOR) deps: update V8 to 8.4.371.19 (Michaël Zasso) #3357924f76cf004
] - deps: upgrade npm to 6.14.6 (claudiahdz) #34246a9ca4204e0
] - deps: upgrade to libuv 1.38.1 (Colin Ihrig) #34187601ed8ef7e
] - deps: V8: backport 2d5017a0fc02 (Benjamin Coe) #3427217174e69ce
] - doc: clarify conditional exports guidance (Guy Bedford) #343061dd265384b
] - doc: reword warnings about sockets passed to subprocesses (Rich Trott) #34273ef31f179e0
] - doc: sync deprecation numbers with v14.x (Myles Borins) #343680b42e5d205
] - doc: add danielleadams to collaborators (Danielle Adams) #343601cc65332b0
] - doc: buffer documentation improvements (James M Snell) #34230d11496174d
] - doc: improve text in fs docs about omitting callbacks (Rich Trott) #34307d2c58948e9
] - doc: add sxa as collaborator (Stewart X Addison) #34338d865be4cab
] - doc: move sebdeckers to emeritus (Rich Trott) #3429824fe55872f
] - doc: add ruyadorno to collaborators (Ruy Adorno) #34297e6776fe194
] - doc: move kfarnung to collaborator emeriti list (Rich Trott) #342587416028f99
] - doc: specify encoding in text/html examples (James M Snell) #342229339f9f602
] - doc: document the ready event for Http2Stream (James M Snell) #3422125ac669be9
] - doc: add comment to example about 2xx status codes (James M Snell) #342236f014d0b13
] - doc: document that whitespace is ignored in base64 decoding (James M Snell) #34227431bfe177f
] - doc: add note about multiple sync events and once (James M Snell) #34220ffe6886de9
] - doc: document behavior for once(ee, 'error') (James M Snell) #34225a6a656abaa
] - doc: document security issues with url.parse() (James M Snell) #34226abfab9892b
] - doc: replace http to https of link urls (sapics) #341582e20cd4fde
] - doc: remove errors that were never released (Rich Trott) #34197c83d98619d
] - doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors (Rich Trott) #3419659bb6d6663
] - doc: move digitalinfinity to emeritus (Rich Trott) #3419139d6ecdea9
] - doc: move gibfahn to emeritus (Rich Trott) #34190938de338ef
] - doc: specify how fs.WriteStream/ReadStreams are created (James M Snell) #34188326b854e6e
] - doc: remove parenthetical \r\n comment in http and http2 docs (Rich Trott) #34178a2dd2589c1
] - doc: remove stability from unreleased errors (Rich Trott) #337648dd8b1a8be
] - doc: util.debuglog callback (Bradley Meck) #33856aaba1c08dc
] - doc: update wording in "Two reading modes" (Julien Poissonnier) #341196aa0dac362
] - doc: clarify that the ctx argument is optional (Luigi Pinca) #340971558800217
] - doc: add a reference to the list of OpenSSL flags. (Mateusz Krawczuk) #3405025d310b631
] - doc: no longer maintain a CNA structure (Sam Roberts) #336395ae2b74350
] - doc: use consistent naming in stream doc (Saleem) #30506a0cfa62338
] - doc: clarify how to read process.stdin (Anentropic) #27350e8184554ba
] - doc: fix entry fornapi\_create\_external\_buffer
(Gabriel Schulhof) #34125167a21a66a
] - doc: fix source link margin to sub-header mark (Rodion Abdurakhimov) #33664146538de65
] - doc: improve async_hooks asynchronous context example (Denys Otrishko) #33730e386188775
] - doc: clarify esm conditional exports prose (Derek Lewis) #33886e273edf943
] - doc: Add maxTotalSockets option to agent constructor (rickyes) #34013ab6b786e9d
] - doc: add streams to the pipeline function signature (rickyes) #341539f0bf5c9e1
] - doc: improve triaging text in issues.md (Rich Trott) #3416422c1fbf4cb
] - doc: simply dns.ADDRCONFIG language (Rich Trott) #341557fc56ebd0d
] - doc: remove "considered" in errors.md (Rich Trott) #34152e33c09cb3a
] - doc: simplify and clarify ReferenceError material in errors.md (Rich Trott) #34151af9e6f6e1b
] - doc: add http highlight grammar (Derek Lewis) #3378526ecdf8ade
] - doc: move sam-github to TSC Emeriti (Sam Roberts) #3409578a4d97b82
] - doc: change "considered experimental" to "experimental" in n-api.md (Rich Trott) #34129da5fde6594
] - doc: changed "considered experimental" to "experimental" in cli.md (Rich Trott) #3412849d2d49336
] - doc: improve text in issues.md (falguniraina) #339739d30f0542c
] - doc: change "currently not considered public" to "not supported" (Rich Trott) #3411464bd518f26
] - doc: clarify that APIs are no longer experimental (Rich Trott) #34113ee6ccef091
] - doc: clarify O_EXCL text in fs.md (Rich Trott) #3409605a69e2e88
] - doc: clarify ambiguous rdev description (Rich Trott) #340944927fed9ea
] - doc: make minor improvements to paragraph in child_process.md (Rich Trott) #34063585f3a5f84
] - doc: improve paragraph in esm.md (Rich Trott) #34064556e55db72
] - doc: clarify require/import mutual exclusivity (Guy Bedford) #33832eb04ba3080
] - doc: add dynamic source code links (Alec Davidson) #339962ca6a45ba9
] - doc: mention errors thrown by methods called on an unbound dgram.Socket (Mateusz Krawczuk) #33983b8a17ccc9a
] - doc: document n-api callback scope usage (Gabriel Schulhof) #339153b268094cc
] - doc: use sentence-case for headings in docs (Rich Trott) #33889280cd967d3
] - domain: fix unintentional deprecation warning (Anna Henningsen) #3424596ebd5f352
] - http: add note about timer unref (Robert Nagy) #3414316160e654f
] - Revert "http2: streamline OnStreamRead streamline memory accounting" (Rich Trott) #343158bafba2e56
] - lib: always initialize esm loader callbackMap (Shelley Vohr) #34127daf2abf393
] - lib: replace http to https of comment link urls (sapics) #341588f8d16849c
] - meta: make issue template mobile friendly and address nits (Derek Lewis) #34243de58eb6286
] - meta: add N-API to codeowners coverage (Michael Dawson) #340394dc89c6d30
] - meta: fixup CODEOWNERS so it hopefully works (James M Snell) #341478d7330be0e
] - (SEMVER-MINOR) module: deprecate module.parent (Antoine du HAMEL) #322171ae76bd075
] - (SEMVER-MINOR) module: package "imports" field (Guy Bedford) #341170e1361cb8b
] - net: doc deprecate bufferSize (Robert Nagy) #34088b7e9b43b2f
] - net: fix bufferSize (Robert Nagy) #3408802ea320e0c
] - policy: add startup benchmark and make SRI lazier (Bradley Farias) #2952773d6792a05
] - repl: support --loader option in builtin REPL (Michaël Zasso) #33437b20e6ed94e
] - repl: fix verb conjugation in deprecation message (Rich Trott) #34198b878e3223e
] - src: add callback scope for native immediates (Anna Henningsen) #343660f6805d507
] - (SEMVER-MINOR) src: add option to track unmanaged file descriptors (Anna Henningsen) #34303e4c7b59665
] - (SEMVER-MINOR) src: allow embedders to disable esm loader (Shelley Vohr) #340609c12e53d47
] - src: remove redundant snprintf (Anna Henningsen) #34282844bf770f8
] - src: use FromMaybe instead of ToLocal in GetCert (Daniel Bevenius) #34276ec876eecc0
] - src: add GetCipherValue function (Daniel Bevenius) #342879c98af71db
] - src: exit explicitly after printing V8 help (Anna Henningsen) #341363e3d908c81
] - src: add encoding_type variable in WritePrivateKey (Daniel Bevenius) #34181ed0f5697d8
] - src: fix minor comment typo in KeyObjectData (Daniel Bevenius) #341678f7ed40fc4
] - src: fix unused namespace member (Nikola Glavina) #34212e378b681d0
] - src: remove unused fields from IsolateData (Anna Henningsen) #34139b2cd87e611
] - src,doc,test: remove String::New default parameter (Anna Henningsen) #3424841c80f6abe
] - stream: destroy wrapped streams on error (Robert Nagy) #341021af8943622
] - (SEMVER-MINOR) test: remove test/v8-updates/test-postmortem-metadata.js (Colin Ihrig) #3357958dfeac133
] - test: use mustCall() in pummel test (Rich Trott) #3432728ce378e17
] - test: fix flaky test-http2-reset-flood (Rich Trott) #34318060c95a3b1
] - test: add n-api null checks for conversions (Gabriel Schulhof) #341423ee8f5342c
] - test: add regression tests for HTTP parser crash (Anna Henningsen) #342506925ef3b1c
] - test: add WASI test for file resizing (Colin Ihrig) #316171aad61eeec
] - test: add issue ref for known_issues test (Rich Trott) #34267ec9b49a9b9
] - test: add known issue for fs.open() keeping event loop open (Rich Trott) #3422838b3c2a300
] - test: add arrayOfStreams to pipeline (rickyes) #341560f9bafd03d
] - test: skip an ipv6 test on IBM i (Xu Meng) #34209a38219f962
] - test: add regression test for C++-created Buffer transfer (Anna Henningsen) #3414009faebd9ad
] - test: replace deprecated function call from test-repl-history-navigation (Rich Trott) #34199bddc99ec7f
] - test: skip some IBM i unsupported test cases (Xu Meng) #34118f5691fa6b6
] - test: report actual error code on failure (Richard Lau) #3413446d183c86e
] - test: update test-child-process-spawn-loop for Python 3 (Richard Lau) #34071a89bcf72fb
] - (SEMVER-MINOR) tls: make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974fbcd1fa0f4
] - tls: remove unnecessary close listener (Robert Nagy) #341054e2fa439c9
] - (SEMVER-MINOR) tools: update V8 gypfiles for 8.4 (Ujjwal Sharma) #33579440642d00b
] - tools: remove lint-js.js (Rich Trott) #30955e0206bafe6
] - util: restrict custom inspect function + vm.Context interaction (Anna Henningsen) #3369070c4045aa5
] - (SEMVER-MINOR) vm: add run-after-evaluate microtask mode (Anna Henningsen) #340236be685a99d
] - wasi: add reactor support (Gus Caplan) #340461bc4def18f
] - worker: fix nested uncaught exception handling (Anna Henningsen) #343109e04070d3c
] - (SEMVER-MINOR) worker: add option to track unmanaged file descriptors (Anna Henningsen) #34303105d5607a8
] - zlib: remove redundant variable in zlibBufferOnEnd (Andrey Pechkurov) #34072