build,tools: fix cmd_regen_makefile #34255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
nodejs-github-bot
added
build
bnoordhuis
approved these changes
Jul 8, 2020
jasnell
approved these changes
Jul 8, 2020
This was referenced Jul 9, 2020
danbev
added
the
author ready
10 tasks
danbev
added a commit
that referenced
this pull request
Jul 14, 2020
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
PR-URL: #34255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
|
Landed in 8da0ae2. |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
PR-URL: #34255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jul 15, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
PR-URL: #34255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
PR-URL: #34255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
PR-URL: #34255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2
The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake
As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
...
'gyp_binary': sys.argv[0],
But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
PR-URL: #34255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:
The reason for this is that the target
cmd_regen_makefileis using thecommand
configureinstead ofgyp_node.pyin out/Makefile:As far as I can tell gyp is using
sys.argv[0]as thegyp_binaryin__init__.py:But when called via 'configure' sys.argv[0] is 'configure' instead of gyp_node.py
leading to the above error.
This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes