-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about multiple sync events and once #34220
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
events
Issues and PRs related to the events subsystem / EventEmitter.
labels
Jul 6, 2020
lpinca
reviewed
Jul 6, 2020
lpinca
approved these changes
Jul 6, 2020
jasnell
commented
Jul 7, 2020
jasnell
commented
Jul 7, 2020
jasnell
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jul 7, 2020
antsmartian
approved these changes
Jul 8, 2020
trivikr
approved these changes
Jul 9, 2020
jasnell
added a commit
that referenced
this pull request
Jul 9, 2020
Fixes: #32431 PR-URL: #34220 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Landed in 62bdb7e |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Fixes: #32431 PR-URL: #34220 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Fixes: #32431 PR-URL: #34220 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Sep 27, 2020
Fixes: #32431 PR-URL: #34220 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 28, 2020
Fixes: #32431 PR-URL: #34220 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
events
Issues and PRs related to the events subsystem / EventEmitter.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #32431
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes