Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "http2: streamline OnStreamRead streamline memory accounting" #34315

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 11, 2020

This reverts commit 51ccf1b.

Fixes: #31089

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. labels Jul 11, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 11, 2020

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

CI passed on the first try, so that's encouraging. I'm going to set up two CI jobs to confirm that this change fixes the flaky test.

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

CI stress test with this change (should pass): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37209/

CI stress test on master branch without this change (should fail a lot): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37210/

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

CI stress test with this change (should pass): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37209/

CI stress test on master branch without this change (should fail a lot): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37210/

Results are as expected.

cc other approvers of original PR: @devnexen @jasnell

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2020
src/node_http2.cc Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Jul 14, 2020

Landed in e1b336f

Trott added a commit that referenced this pull request Jul 14, 2020
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@Trott Trott closed this Jul 14, 2020
@Trott Trott deleted the fix-31089 branch July 14, 2020 14:29
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
lundibundi added a commit to lundibundi/node that referenced this pull request Jul 22, 2020
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
mcollina pushed a commit that referenced this pull request Jul 27, 2020
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
clshortfuse pushed a commit to clshortfuse/node that referenced this pull request Oct 7, 2020
This reverts commit 51ccf1b.

Fixes: nodejs#31089

PR-URL: nodejs#34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 13, 2020
This reverts commit 51ccf1b.

Fixes: #31089

Backport-PR-URL: #34845
PR-URL: #34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 3, 2020
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
This reverts commit 51ccf1b.

Fixes: #31089

Backport-PR-URL: #34845
PR-URL: #34315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-large-writes-session-memory-leak on Windows CI
7 participants