http2: avoid unnecessary buffer resize

Refs: #34315 Refs: #30351 PR-URL: #34480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
nodejs · Jul 27, 2020 · 62198d2 · 62198d2
1 parent 3e6b05e
commit 62198d2
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -1761,7 +1761,10 @@ void Http2Session::OnStreamRead(ssize_t nread, const uv_buf_t& buf_) {
 
   statistics_.data_received += nread;
 
-  if (UNLIKELY(stream_buf_offset_ > 0)) {
+  if (LIKELY(stream_buf_offset_ == 0)) {
+    // Shrink to the actual amount of used data.
+    buf.Resize(nread);
+  } else {
     // This is a very unlikely case, and should only happen if the ReadStart()
     // call in OnStreamAfterWrite() immediately provides data. If that does
     // happen, we concatenate the data we received with the already-stored
@@ -1782,8 +1785,6 @@ void Http2Session::OnStreamRead(ssize_t nread, const uv_buf_t& buf_) {
     DecrementCurrentSessionMemory(stream_buf_.len);
   }
 
-  // Shrink to the actual amount of used data.
-  buf.Resize(nread);
   IncrementCurrentSessionMemory(nread);
 
   // Remember the current buffer, so that OnDataChunkReceived knows the