fix #118 #120
Merged
fix #118 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
commented
Nov 6, 2018
Varriount
requested changes
Nov 6, 2018
|
PTAL |
Varriount
requested changes
Nov 6, 2018
Co-Authored-By: timotheecour <[email protected]>
|
applied your suggestion, PTAL |
Varriount
pushed a commit
that referenced
this pull request
Dec 29, 2018
* Move core files to 'core' directory. Remove Nimsuggest and Nimble support. * Refactor settings, hotkeys, and nimcheck code. * Fix #110 * Fix file permissions. * fix #118 (#120) * fix #118 * Update core/commands/nimcheck.py Co-Authored-By: timotheecour <[email protected]> * Make command import more correct. * fix #112 (#123) * Split comment grammer into separate file, to support nested multiline comments. Fixes #94 * Update keymaps for new comment definitions. Fixes #94, #97, and #128 * Straighten out TODO matching. * Simplify package settings menu by using native edit_settings command. * Fix comment continuation. * Remove ST2/ST3 distinction. * comment and doc comment completion work (#133) * fix #134 (#135) * fix #125 (#127) * should fix #125 (hopefully) let me know if I'm mistaken * Update Nim.YAML-tmLanguage (#126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Varriount
fixes
nim checkerrors don't show up on branchrestructure-for-st3#118I'm really curious how you created restructure-for-st3 branch, I had already fixed that problem (the original one in nothing works, eg: nimcheck output is run but doesn't show anything (even if there are obvious errors) #113) in faca2c5 (via several fixes #114) but the problem reappeared, indeed, the code I changed in https://github.com/Varriount/NimLime/pull/114/files#diff-28afad5cba5c8e77ff81851ab73d52c9R127 was reverted ; was that the result of an error in merge conflict resolution?