Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim check errors don't show up on branch restructure-for-st3 #118

Closed
timotheecour opened this issue Nov 6, 2018 · 2 comments
Closed

nim check errors don't show up on branch restructure-for-st3 #118

timotheecour opened this issue Nov 6, 2018 · 2 comments

Comments

@timotheecour
Copy link
Member

/cc @Varriount
on branch master nim check errors do show up
on branch restructure-for-st3 nim check errors don't show up anymore...

@Varriount
Copy link
Collaborator

Can you please post the contents of your user settings? I'm not encountering this issue.
Also, what OS are you using?

@timotheecour
Copy link
Member Author

upon further inspection this is a regression : I had fixed this bug 3 days ago in #114 but the issue came back with branch estructure-for-st3

the relevant setting is --listFullPaths in ~/.config/nim/nim.cfg which causes absolute paths (which I handled correctly in #114)

I'm on OSX

Can you please post the contents of your user settings? I'm not encountering this issue.

shouldn't be relevant but here goes:

{
    "check.on_save.enabled": true, 
    "nim.executable": "/Users/timothee/.nimble/bin/nim",
    "debug_mode": true,
    "nimsuggest.executable": "/Users/timothee/.nimble/bin/nimsuggest",
    "error_handler.logfile_path": "/tmp/nimline.logs",
}


timotheecour added a commit to timotheecour/NimLime that referenced this issue Nov 6, 2018
@timotheecour timotheecour mentioned this issue Nov 6, 2018
Varriount pushed a commit that referenced this issue Nov 6, 2018
* fix #118

* Update core/commands/nimcheck.py

Co-Authored-By: timotheecour <[email protected]>
Varriount pushed a commit that referenced this issue Dec 29, 2018
* Move core files to 'core' directory.
Remove Nimsuggest and Nimble support.

* Refactor settings, hotkeys, and nimcheck code.

* Fix #110

* Fix file permissions.

* fix #118 (#120)

* fix #118

* Update core/commands/nimcheck.py

Co-Authored-By: timotheecour <[email protected]>

* Make command import more correct.

* fix #112 (#123)

* Split comment grammer into separate file, to support nested multiline comments.
Fixes #94

* Update keymaps for new comment definitions.
Fixes #94, #97, and #128

* Straighten out TODO matching.

* Simplify package settings menu by using native edit_settings command.

* Fix comment continuation.

* Remove ST2/ST3 distinction.

* comment and doc comment completion work (#133)

* fix #134 (#135)

* fix #125 (#127)

* should fix #125 (hopefully)
let me know if I'm mistaken

* Update Nim.YAML-tmLanguage (#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants