Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logpath is wrong; code uses logfile_path #112

Closed
timotheecour opened this issue Nov 3, 2018 · 2 comments
Closed

logpath is wrong; code uses logfile_path #112

timotheecour opened this issue Nov 3, 2018 · 2 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Nov 3, 2018

but still after this change, nothing gets written to logfile_path

I'm using this (after having made sure /tmp/nimline.logs is writable); /tmp/nimline.logs/NimLime-Log.txt stays empty

"error_handler.logfile_path": "/tmp/nimline.logs",
@Varriount
Copy link
Collaborator

Data is only written to the log file when there's an error - did you test this by causing an error in NimLime?

@timotheecour
Copy link
Member Author

both by reading your code and (IIRC) causing an error:

core/utils/error_handler.py:112:5:    logfile_path = settings.get('error_handler.logfile_path')

so these seem wrong:

NimLime.sublime-settings:8:20:    "error_handler.logpath": "",
core/utils/error_handler.py:48:57:NimLime plugin is writeable, or that the 'error_handler.logpath' setting in

I was gonna make a PR but now you have 2 main branches, master and restructure-for-st3 so not sure which to target (btw I think we should merge to master soon to avoid this; is that meant as a trial period to make sure it all works before pushing to master?)

timotheecour added a commit to timotheecour/NimLime that referenced this issue Nov 6, 2018
@timotheecour timotheecour mentioned this issue Nov 6, 2018
Varriount pushed a commit that referenced this issue Nov 6, 2018
Varriount pushed a commit that referenced this issue Dec 29, 2018
* Move core files to 'core' directory.
Remove Nimsuggest and Nimble support.

* Refactor settings, hotkeys, and nimcheck code.

* Fix #110

* Fix file permissions.

* fix #118 (#120)

* fix #118

* Update core/commands/nimcheck.py

Co-Authored-By: timotheecour <[email protected]>

* Make command import more correct.

* fix #112 (#123)

* Split comment grammer into separate file, to support nested multiline comments.
Fixes #94

* Update keymaps for new comment definitions.
Fixes #94, #97, and #128

* Straighten out TODO matching.

* Simplify package settings menu by using native edit_settings command.

* Fix comment continuation.

* Remove ST2/ST3 distinction.

* comment and doc comment completion work (#133)

* fix #134 (#135)

* fix #125 (#127)

* should fix #125 (hopefully)
let me know if I'm mistaken

* Update Nim.YAML-tmLanguage (#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants