Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

every binary cmd line option should allow on/off switch #9629

Closed
timotheecour opened this issue Nov 6, 2018 · 0 comments · Fixed by #10353
Closed

every binary cmd line option should allow on/off switch #9629

timotheecour opened this issue Nov 6, 2018 · 0 comments · Fixed by #10353
Assignees
@krux02 @timotheecour
Labels
RFC: Accepted

Comments

@timotheecour
Copy link
Member

as an example, --listFullPaths doesn't allow --listFullPaths:off; so it can't be undone if user has it in ~/.config/nim/nim.cfg
this would've allowed a simple fix for nim-lang/NimLime#118 where root cause was that --listFullPaths was not being supported
there are other examples like that.

proposal

every binary switch can be passed an on/off value, eg:

--listFullPaths # still allowed
--listFullPaths:on # same as --listFullPaths
--listFullPaths:off # unsets --listFullPaths

implementation: just use processOnOffSwitch
@krux02 krux02 self-assigned this Nov 6, 2018
@timotheecour timotheecour mentioned this issue Nov 7, 2018
Closed
@narimiran narimiran removed the RFC label Jan 2, 2019
timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 18, 2019
@timotheecour
fix nim-lang#9629 every binary cmd line option allows on/off/empty=on
fb4968a
@timotheecour timotheecour mentioned this issue Jan 18, 2019
Merged
@timotheecour timotheecour self-assigned this Jan 18, 2019
Araq pushed a commit that referenced this issue Jan 18, 2019
@timotheecour @Araq
fix #9629 every binary cmd line option allows on/off/empty=on (#10353)
27e2ed4 
* fix #9629 every binary cmd line option allows on/off/empty=on

* workaround refs #10359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krux02 krux02

@timotheecour timotheecour

Labels
RFC: Accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #9629 every binary cmd line option allows on/off/empty=on timotheecour/Nim
4 participants
@Araq @krux02 @timotheecour @narimiran