Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #118 #120

Merged
merged 2 commits into from
Nov 6, 2018
Merged

fix #118 #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cca7d
fix #118
timotheecour Nov 6, 2018
244aa70
Update core/commands/nimcheck.py
Varriount Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions core/commands/nimcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def run_nimcheck(file_path, callback, verbosity, disabled_hints, extra_args):
yield callback(None)

entries = parse_nimcheck(stdout)
sublime.status_message('Nim Check Finished.')
sublime.status_message('run_nimcheck:Nim Check Finished.')
Varriount marked this conversation as resolved.
Show resolved Hide resolved

yield callback(entries)

Expand Down Expand Up @@ -246,7 +246,7 @@ def run(self, *args, **varargs):
if entries is None:
sublime.status_message('Nim Check Failed.')
yield
sublime.status_message('Nim Check Finished.')
sublime.status_message('run:Nim Check Finished.')

self.highlight_and_list_entries(entries, window, view)

Expand Down Expand Up @@ -319,7 +319,14 @@ def highlight_and_list_entries(self, entries, window, view):
error_entries.send(None)
warn_entries.send(None)
for entry in entries:
if entry.file_name.lower() != view_name.lower():

# makes it work when `--listFullPaths` is in user config
# TODO: Make this more robust if/when multiple names are allowed,
# PENDING https://github.com/nim-lang/Nim/pull/8614
file_name = entry.file_name
file_name = os.path.basename(file_name)

if file_name.lower() != view_name.lower():
timotheecour marked this conversation as resolved.
Show resolved Hide resolved
continue

# Determine whether the entry should be highlighted/listed
Expand Down