Pseudo PR - Do not merge! #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First Release
Release 1.0.0
Post release version bump
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: FriederikeHanssen <[email protected]>
Co-authored-by: FriederikeHanssen <[email protected]>
Co-authored-by: FriederikeHanssen <[email protected]>
Co-authored-by: FriederikeHanssen <[email protected]>
Co-authored-by: FriederikeHanssen <[email protected]>
Co-authored-by: FriederikeHanssen <[email protected]>
JoseEspinosa
requested changes
May 10, 2023
|
Thanks for the review @JoseEspinosa! I applied your suggestions in the PR #54. Could you take another look, please? 🙏 |
Apply code review suggestions
sateeshperi
reviewed
May 12, 2023
maxulysse
approved these changes
May 12, 2023
|
@JoseEspinosa : since you requested changes, is there anything else I should add to the current Code review PR #55 ? |
|
@maxulysse Thanks for the review! |
Code review & formatting
Add Dependencies in changelog
Add new zenodo doi
|
Approved by three, will merge #50 to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to qbic-pipelines/bamtofastq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
testdata/nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md