First Release #15
Merged
First Release #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggabernet
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Hi Rike, thanks for the PR!
For the tests to run, you can fix the container pulling and tagging as suggested. Additionally, we try to do release tags with 1.0.0 rather than 1.0. Do you think that you could still change it with bump-versions?
Additionally, there is an updated github actions CI workflow and a new container pushing workflow in the template that are quite useful. Maybe you could update these?
Co-authored-by: Gisela Gabernet <[email protected]>
ggabernet
reviewed
Sep 8, 2020
Co-authored-by: Gisela Gabernet <[email protected]>
ggabernet
requested changes
Sep 9, 2020
|
@ggabernet let's see if this works now |
ggabernet
reviewed
Sep 9, 2020
Co-authored-by: Gisela Gabernet <[email protected]>
ggabernet
approved these changes
Sep 9, 2020
|
waiting on the tests to pass before merging |
ggabernet
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggabernet I realised that my branch was not named correctly and their was no docker image built triggered. which is why I have now renamed the branch.
Many thanks to contributing to nf-core/bamtofastq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/bamtofastq/tree/master/.github/CONTRIBUTING.md