Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review from Pseudo PR #53

Merged
merged 6 commits into from
May 10, 2023
Merged

Code review from Pseudo PR #53

merged 6 commits into from
May 10, 2023

Conversation

SusiJo
Copy link
Collaborator

@SusiJo SusiJo commented May 5, 2023

Many thanks to contributing to nf-core/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, add test data to testdata/
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/bamtofastq/tree/master/.github/CONTRIBUTING.md

@SusiJo SusiJo mentioned this pull request May 5, 2023
8 tasks
@SusiJo SusiJo requested a review from maxulysse May 5, 2023 15:06
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SusiJo SusiJo merged commit ba64646 into nf-core:dev May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants