-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 #16
Merged
Merged
Release 1.0.0 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reading in a bam file, report error if param is not specified or file does not exists.
Fix README, GHA, remove nf-core in the last places
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
First Release
ggabernet
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
@@ -1,4 +1,4 @@ | |||
# nf-core/bamtofastq: Changelog | |||
|
|||
## v1.0dev - [date] | |||
Initial release of nf-core/bamtofastq, created with the [nf-core](http://nf-co.re/) template. | |||
## v1.0.0 - Ada Lovelace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool release name! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First release version
@ggabernet I now bumped the versions in the
Dockerfile, environment.yml, nextflow.config, CHANGELOG, and ci.yml
Many thanks to contributing to nf-core/bamtofastq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/bamtofastq/tree/master/.github/CONTRIBUTING.md