feat(files_sharing): Migrate public shares to Vue #45652

susnux · 2024-06-04T01:13:31Z

Resolves: Migrate public files to the same Files UI #42968
Resolves: Allow chunked public upload #4109
- Resolves: Resume chunked uploads #673
Resolves: [Bug]: Issue with File Previews in Shared Folders on Nextcloud 29.0 #45510
Resolves: Move permission for shared files/subfolders #44404
Resolves: Support quick file search on public shares #45448
Resolves: Edit locally on public shares look broken #46935
Resolves: [Bug]: Uploading large file to public deposit folder should not show "done" when the file is being processed #42770
Resolves: Allow pasting in public upload #34878
Resolves: image share bulk uploading is slow and unreliable #13696
Resolves: [Bug]: Share by Link / hide download disables Note to Recipient #46189
Closes: Use webpack+handlebars-loader for the Handlebars precompilation #13205

Summary

Folder view
Split of "note-to-recipient" fix(files_sharing): Add missing "note to recipient" #46892

TODO

needs feat: Implement upload on public shares using dav endpoint v2 nextcloud-libraries/nextcloud-upload#1225
needs a new nextcloud-upload release (1.3.1+)
needs a new nextcloud-files release (3.5.1+)
needs a new nextcloud-dialog release (with that files release used)
File drop
Single file view

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php

apps/files/src/actions/favoriteAction.ts

apps/files/src/services/RouterService.ts

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php

Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>

…ion for public shares Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

…the router to allow injecting the `files_sharing` router Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

…` permission Signed-off-by: Ferdinand Thiessen <[email protected]>

…c and internal shares Signed-off-by: Ferdinand Thiessen <[email protected]>

This is disabled to not leak personal information into the public Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

This is needed because some views have side effects, like `favorites` doing requests on registration time. Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

This will disable "New folder" menu entry for file-drop shares. Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

…n public shares Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

szaimen · 2024-09-06T11:30:52Z

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

skjnldsv

🎉 🎉 🎉 🎉

susnux added the 2. developing Work in progress label Jun 4, 2024

susnux mentioned this pull request Jun 4, 2024

feat: Implement upload on public shares using dav endpoint v2 nextcloud-libraries/nextcloud-upload#1225

Merged

github-advanced-security bot found potential problems Jun 4, 2024

View reviewed changes

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php Fixed Show fixed Hide fixed

susnux added enhancement feature: files labels Jun 4, 2024

susnux added this to the Nextcloud 30 milestone Jun 4, 2024

skjnldsv reviewed Jun 4, 2024

View reviewed changes

apps/files/src/actions/favoriteAction.ts Outdated Show resolved Hide resolved

skjnldsv reviewed Jun 4, 2024

View reviewed changes

apps/files/src/services/RouterService.ts Outdated Show resolved Hide resolved

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch from 8d02b52 to fe796c0 Compare June 11, 2024 13:33

susnux added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jun 17, 2024

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch 4 times, most recently from 7fe567d to a7272ac Compare June 20, 2024 15:18

This comment was marked as resolved.

Sign in to view

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch 3 times, most recently from f1c2ec5 to 21fd6da Compare June 21, 2024 19:01

This comment was marked as resolved.

Sign in to view

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch 2 times, most recently from b38ab4d to dc37f4b Compare June 28, 2024 15:27

github-advanced-security bot found potential problems Jun 28, 2024

View reviewed changes

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php Fixed Show fixed Hide fixed

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch 2 times, most recently from a4fc840 to 5ba308d Compare July 30, 2024 16:42

skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Jul 31, 2024

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch 2 times, most recently from e85f4cd to 3b85671 Compare July 31, 2024 14:37

skjnldsv mentioned this pull request Jul 31, 2024

fix(files): do not show legacy edit locally action on public pages #46927

Merged

susnux and others added 21 commits September 6, 2024 03:38

feat(files_sharing): Migrate public share to use Vue files list

96c8275

Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Do not use favorite, sidebar and view-in-folder act…

767e87a

…ion for public shares Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Fix file previews for public shares

819f5ce

Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Adjust files list for sharing permissions on public shares

82a7a39

Signed-off-by: Ferdinand Thiessen <[email protected]>

refactor(files): Make RouterService provide a protected getter for …

f109c1a

…the router to allow injecting the `files_sharing` router Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Disable copy-move-action of single file shares

f0a765e

Signed-off-by: Ferdinand Thiessen <[email protected]>

refactor(files_sharing): Make file structure more clear

563f8e7

Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Do not allow rename action on single-file-shares

ada6a61

Signed-off-by: Ferdinand Thiessen <[email protected]>

feat(files): Allow to download files on public shares

a84de3c

Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Do not allow copy action on public shares without `create…

e93ceea

…` permission Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files_sharing): Handle download permission the same way for publi…

1d16bc4

…c and internal shares Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files_sharing): Disable sharing status action for public shares

3134053

This is disabled to not leak personal information into the public Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files_sharing): Set file-request header for nextcloud/upload

1dafdce

Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Disable internal views on public shares

80033bd

This is needed because some views have side effects, like `favorites` doing requests on registration time. Signed-off-by: Ferdinand Thiessen <[email protected]>

chore(files_sharing): Remove now unused legacy scripts

11fdf4e

Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): "New folder" menu entry requires read permission

c9dc0af

This will disable "New folder" menu entry for file-drop shares. Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files_sharing): Ensure sidebar share entry lists are labelled

cb4c569

Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): Do not add click listener if there is no default action o…

018af2a

…n public shares Signed-off-by: Ferdinand Thiessen <[email protected]>

fix(files): "Edit locally" action should not be shown on public shares

be884ee

Signed-off-by: Ferdinand Thiessen <[email protected]>

test: Add end-to-end tests for new public share Vue UI

4a90d53

Signed-off-by: Ferdinand Thiessen <[email protected]>

chore: Compile assets

6249125

Signed-off-by: Ferdinand Thiessen <[email protected]>

susnux force-pushed the feat/migrate-files-sharing-public-to-vue branch from 7988651 to 6249125 Compare September 6, 2024 01:39

susnux merged commit 219f1f9 into master Sep 6, 2024
174 checks passed

susnux deleted the feat/migrate-files-sharing-public-to-vue branch September 6, 2024 11:17

skjnldsv reviewed Sep 6, 2024

View reviewed changes

sorbaugh added the 🍀 2025-Spring label Sep 10, 2024

juliusknorr mentioned this pull request Sep 16, 2024

Bring new template file creation to public share links #48064

Open

danxuliu mentioned this pull request Sep 26, 2024

Talk sidebar not shown for public shares in Nextcloud 31 nextcloud/spreed#13402

Closed

szaimen mentioned this pull request Oct 22, 2024

Add ENV variables to adjust max_file_uploads and max_chunk_size nextcloud/all-in-one#5449

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(files_sharing): Migrate public shares to Vue #45652

feat(files_sharing): Migrate public shares to Vue #45652

susnux commented Jun 4, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

szaimen commented Sep 6, 2024

skjnldsv left a comment

feat(files_sharing): Migrate public shares to Vue #45652

feat(files_sharing): Migrate public shares to Vue #45652

Conversation

susnux commented Jun 4, 2024 • edited Loading

Summary

TODO

Checklist

This comment was marked as resolved.

This comment was marked as resolved.

szaimen commented Sep 6, 2024

skjnldsv left a comment

Choose a reason for hiding this comment

susnux commented Jun 4, 2024 •

edited

Loading