Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files_sharing): Migrate public shares to Vue #45652

Merged
merged 21 commits into from
Sep 6, 2024
Merged

feat(files_sharing): Migrate public shares to Vue #45652

merged 21 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. feat(files_sharing): Migrate public share to use Vue files list 

    Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux @come-nc
    susnux and come-nc committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    96c8275 View commit details
    Browse the repository at this point in the history

  2. fix(files): Do not use favorite, sidebar and view-in-folder act… 

    …ion for public shares

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    767e87a View commit details
    Browse the repository at this point in the history

  3. fix(files): Fix file previews for public shares 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    819f5ce View commit details
    Browse the repository at this point in the history

  4. fix(files): Adjust files list for sharing permissions on public shares 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    82a7a39 View commit details
    Browse the repository at this point in the history

  5. refactor(files): Make RouterService provide a protected getter for … 

    …the router to allow injecting the `files_sharing` router

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f109c1a View commit details
    Browse the repository at this point in the history

  6. fix(files): Disable copy-move-action of single file shares 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f0a765e View commit details
    Browse the repository at this point in the history

  7. refactor(files_sharing): Make file structure more clear 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    563f8e7 View commit details
    Browse the repository at this point in the history

  8. fix(files): Do not allow rename action on single-file-shares 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ada6a61 View commit details
    Browse the repository at this point in the history

  9. feat(files): Allow to download files on public shares 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a84de3c View commit details
    Browse the repository at this point in the history

  10. fix(files): Do not allow copy action on public shares without `create… 

    …` permission

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e93ceea View commit details
    Browse the repository at this point in the history

  11. fix(files_sharing): Handle download permission the same way for publi… 

    …c and internal shares

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1d16bc4 View commit details
    Browse the repository at this point in the history

  12. fix(files_sharing): Disable sharing status action for public shares 

    This is disabled to not leak personal information into the public

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3134053 View commit details
    Browse the repository at this point in the history

  13. fix(files_sharing): Set file-request header for nextcloud/upload 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1dafdce View commit details
    Browse the repository at this point in the history

  14. fix(files): Disable internal views on public shares 

    This is needed because some views have side effects, like `favorites` doing requests on registration time.

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    80033bd View commit details
    Browse the repository at this point in the history

  15. chore(files_sharing): Remove now unused legacy scripts 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    11fdf4e View commit details
    Browse the repository at this point in the history

  16. fix(files): "New folder" menu entry requires read permission 

    This will disable "New folder" menu entry for file-drop shares.

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c9dc0af View commit details
    Browse the repository at this point in the history

  17. fix(files_sharing): Ensure sidebar share entry lists are labelled 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cb4c569 View commit details
    Browse the repository at this point in the history

  18. fix(files): Do not add click listener if there is no default action o… 

    …n public shares

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    018af2a View commit details
    Browse the repository at this point in the history

  19. fix(files): "Edit locally" action should not be shown on public shares 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    be884ee View commit details
    Browse the repository at this point in the history

  20. test: Add end-to-end tests for new public share Vue UI 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4a90d53 View commit details
    Browse the repository at this point in the history

  21. chore: Compile assets 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6249125 View commit details
    Browse the repository at this point in the history