Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit locally on public shares look broken #46935

Closed
susnux opened this issue Jul 31, 2024 · 3 comments · Fixed by #45652
Closed

Edit locally on public shares look broken #46935

susnux opened this issue Jul 31, 2024 · 3 comments · Fixed by #45652
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: sharing

Comments

@susnux
Copy link
Contributor

susnux commented Jul 31, 2024

Bug description

Bildschirmfoto vom 2024-02-13 17-50-23

^ it shows and has a broken icon.

Steps to reproduce

  1. Share a folder by link and give write permission
  2. Open the link
  3. Open the actions menu of a file

Expected behavior

No missing icon
@susnux susnux added bug feature: sharing 0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback labels Jul 31, 2024
@susnux susnux mentioned this issue Jul 31, 2024
Merged
12 tasks
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Aug 9, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2024

What is left over from it?
It's fixed 🤔

@susnux
Copy link
Contributor Author

susnux commented Aug 9, 2024

What is left over from it?

The broken icon was part of the issue and still broken.

@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2024 •
edited
Loading

But we don't use url-icons anymore on the new Files app? 🤔
ALso the broken icon is because OC.imagePath('files', 'computer.svg') doesn't exist anymore, which is fine, we don't need it anymore too 🤷

@susnux susnux closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: sharing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(files_sharing): Migrate public shares to Vue nextcloud/server
2 participants
@susnux @skjnldsv