Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta]: Port away from ILogger #32127

Open
21 of 24 tasks
CarlSchwan opened this issue Apr 25, 2022 · 4 comments · Fixed by #39218 or nextcloud/activity#1251
Open
21 of 24 tasks

[Meta]: Port away from ILogger #32127

CarlSchwan opened this issue Apr 25, 2022 · 4 comments · Fixed by #39218 or nextcloud/activity#1251
Labels
2. developing Work in progress feature: logging good first issue Small tasks with clear documentation about how and in which place you need to fix things in. technical debt

Comments

@CarlSchwan
Copy link
Member

CarlSchwan commented Apr 25, 2022 •
edited by come-nc
Loading

Current pull requests

Current remaining modules to port in server

  • lib/{private,public}/Files

Current remaining shipped app to port

Current issues

  • The background job interface exposes ILogger in its public API. We need to deprecate this
  • In some places, like the updater. It's helpful to be able to write ILogger:DEBUG instead of 2. We need to look if upstream psr would be interested to add enums for the log levels.
@CarlSchwan CarlSchwan added 2. developing Work in progress technical debt good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Apr 25, 2022
@come-nc
Copy link
Contributor

come-nc commented Apr 26, 2022 •
edited
Loading

@come-nc
Copy link
Contributor

come-nc commented Apr 26, 2022 •
edited
Loading

This was referenced Jun 26, 2023
Merged
Merged
@Altahrim Altahrim mentioned this issue Jul 5, 2023
Merged
@Altahrim
Copy link
Collaborator

Altahrim commented Jul 5, 2023 •
edited
Loading

@Altahrim Altahrim mentioned this issue Jul 5, 2023
Merged
@Altahrim
Copy link
Collaborator

Altahrim commented Jul 6, 2023 •
edited
Loading

nfebe added a commit that referenced this issue Jul 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
3dffda9 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe mentioned this issue Jul 7, 2023
Merged
nfebe added a commit that referenced this issue Jul 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
d466c95 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
423b1ae 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
017690a 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
08c9b8a 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
1e8e58f 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit to nextcloud/activity that referenced this issue Jul 9, 2023
@nfebe
Migrate activity app from ILogger
de54ea4 
Migrated files in:

- `lib\AppInfo`
- `lib\Controller`
- `lib\Command`

Resolves : nextcloud/server#32127

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe mentioned this issue Jul 9, 2023
Merged
nfebe added a commit to nextcloud/activity that referenced this issue Jul 9, 2023
@nfebe
Migrate activity app from ILogger
08b1b68 
Migrated files in:

- `lib\AppInfo`
- `lib\Controller`
- `lib\Command`

Resolves : nextcloud/server#32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 13, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
9351b1c 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
@Altahrim Altahrim mentioned this issue Jul 19, 2023
Merged
nfebe added a commit that referenced this issue Jul 21, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
6b81a3f 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 21, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
0d807fa 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 22, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
cbcbc45 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 22, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
a00c390 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 22, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
6bfb9f4 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 22, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
28d4e65 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Jul 22, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
ec4067e 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Aug 3, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
7b7b720 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Aug 7, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
8b6c38b 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Aug 8, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
1bf76b6 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Aug 8, 2023
@nfebe
Migrate parts of files app away from depecrated Ilogger
3ad75c8 
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems`
- Migrate `DirectEditingController`

Resolves :  #32127

Signed-off-by: fenn-cs <[email protected]>
@solracsf solracsf reopened this Aug 13, 2023
@Altahrim Altahrim mentioned this issue Aug 16, 2023
Merged
4 tasks
@come-nc come-nc mentioned this issue Sep 14, 2023
Merged
4 tasks
This was referenced Sep 19, 2023
Merged
Merged
nfebe added a commit to nextcloud/activity that referenced this issue Oct 6, 2023
@nfebe
Migrate activity app from ILogger
590f5ba 
Migrated files in:

- `lib\AppInfo`
- `lib\Controller`
- `lib\Command`

Resolves : nextcloud/server#32127

Signed-off-by: fenn-cs <[email protected]>
@Altahrim Altahrim reopened this Oct 12, 2023
This was referenced Feb 6, 2024
Merged
Merged
@come-nc come-nc mentioned this issue Feb 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. developing Work in progress feature: logging good first issue Small tasks with clear documentation about how and in which place you need to fix things in. technical debt
Projects
None yet
Milestone
No milestone
5 participants
@joshtrichards @Altahrim @solracsf @CarlSchwan @come-nc