Migrate away from ILogger in encryption #39065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991,
nfebe and
artonge
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
approved these changes
Jun 29, 2023
artonge
approved these changes
Jul 3, 2023
| @@ -64,85 +59,44 @@ class Encryption implements IEncryptionModule { | |||
| /** @var string */ | |||
| private $user; | |||
|
|
|||
| /** @var array */ | |||
| private $owner; | |||
| private array $owner; | |||
There was a problem hiding this comment.
Why is it the only one getting a type?
come-nc
force-pushed
the
fix/remove-ilogger-uses-in-encryption
branch
2 times, most recently
from
7b515c1
to
b1a7d07
Compare
And modernize code a bit Signed-off-by: Côme Chilliet <[email protected]>
…tructors Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/remove-ilogger-uses-in-encryption
branch
from
b1a7d07
to
3e176f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate away from ILogger in encryption and switch to constructor parameter promotion in concerned classes.
See #32127
Checklist