Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate files external to PSR LoggerInterface #39480

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Migrate files external to PSR LoggerInterface #39480

merged 1 commit into from
Aug 1, 2023

Conversation

Altahrim
Copy link
Collaborator

See #32127

Summary

Remove OCP\ILogger from apps/files_external and use Psr\Log\LoggerInterface instead.

@Altahrim Altahrim added this to the Nextcloud 28 milestone Jul 19, 2023
@Altahrim Altahrim self-assigned this Jul 19, 2023
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_external branch from 5c008be to 10ca686 Compare July 19, 2023 14:57
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_external branch 6 times, most recently from 5018e64 to aa6e1c5 Compare July 21, 2023 13:15
@Altahrim Altahrim marked this pull request as ready for review July 21, 2023 13:51
@Altahrim Altahrim requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team July 21, 2023 13:51
@Altahrim
Copy link
Collaborator Author

Samba Kerberos SSO failing is a known bug

@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 24, 2023
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_external branch from aa6e1c5 to 9b03dc5 Compare August 1, 2023 07:46
@AndyScherzinger AndyScherzinger merged commit 4c9d589 into master Aug 1, 2023
47 of 48 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/migrate-to-psr-logger-interface-files_external branch August 1, 2023 13:47
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Aug 1, 2023
@Altahrim Altahrim mentioned this pull request Aug 1, 2023
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels
enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@Altahrim @AndyScherzinger @skjnldsv