Cleanup dav #31943
Merged
Cleanup dav #31943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added by @icewind1991 in owncloud/core#9962, maybe they have opinions on this? |
Looking at https://github.com/owncloud-archive/contacts/pull/563/files it seems it is about disabling caldav and the carddav endpoint when the respective apps are disabled. The usage of AppEnabledPlugin has been removed in the two apps since the carddav and caldav backend still work if the calendar and contact apps are disabled or not installed |
|
|
Ah yes this is very very old. 🕸️ 🧹 |
MichaIng
reviewed
Apr 17, 2022
24 tasks
miaulalala
approved these changes
Apr 27, 2022
CarlSchwan
commented
May 2, 2022
- Remove unused class AppEnabledPlugin - Add more type hinting when possible Signed-off-by: Carl Schwan <[email protected]>
|
Also noticed that apps/dav/bin/chunkperf.php is broken (require path is not correct), might be a good idea to remove it completely? |
CarlSchwan
force-pushed
the
dav-cleanup
branch
2 times, most recently
from
fbd2094
to
1d283fc
Compare
come-nc
reviewed
May 12, 2022
come-nc
reviewed
May 12, 2022
come-nc
reviewed
May 12, 2022
come-nc
reviewed
May 12, 2022
apps/dav/lib/CalDAV/InvitationResponse/InvitationResponseServer.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Carl Schwan <[email protected]>
come-nc
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only merge after branching