Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jsonrpc): move request parsing logic to server #6853

Merged
merged 4 commits into from
May 20, 2022
Merged

chore(jsonrpc): move request parsing logic to server #6853

merged 4 commits into from
May 20, 2022

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented May 20, 2022

Tracking issue: #6850

Supercedes: #6849

Move request parsing logic from jsonrpc-primitives to the server.

@miraclx miraclx requested review from frol, matklad and khorolets May 20, 2022 16:48
@miraclx miraclx requested a review from a team as a code owner May 20, 2022 16:48
This was referenced May 20, 2022
Open
Closed
matklad
matklad approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chain/jsonrpc/src/parser.rs Outdated Show resolved Hide resolved
@near-bulldozer near-bulldozer bot merged commit d18f345 into master May 20, 2022
@near-bulldozer near-bulldozer bot deleted the decouple/jsonrpc/extract-request-parser branch May 20, 2022 18:13
nikurt pushed a commit that referenced this pull request May 23, 2022
@miraclx @nikurt
chore(jsonrpc): move request parsing logic to server (#6853)
4b5ab35 
Tracking issue: #6850

Supercedes: #6849

Move request parsing logic from `jsonrpc-primitives` to the server.
@matklad matklad mentioned this pull request May 24, 2022
Merged
@miraclx miraclx mentioned this pull request May 30, 2022
Merged
near-bulldozer bot pushed a commit that referenced this pull request May 31, 2022
@miraclx
chore: bump version to 0.14.0 (#6918)
d70b958 
Tagged: https://github.com/near/nearcore/releases/tag/crates-0.14.0

Notable changes:

  - #6844
  - #6853
  - #6902
  - #6917
  - #6916

Check here for a full changelog: crates-0.13.0...crates-0.14.0

Tested `cargo package` on each public crate locally, they all compile independently of the workspace. We should be good to go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad approved these changes

@frol frol Awaiting requested review from frol

@khorolets khorolets Awaiting requested review from khorolets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miraclx @matklad