Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple jsonrpc-primitives from near-primitives #6850

Open
6 tasks
miraclx opened this issue May 20, 2022 · 1 comment
Open
6 tasks

Decouple jsonrpc-primitives from near-primitives #6850

miraclx opened this issue May 20, 2022 · 1 comment
Assignees

Comments

@miraclx
Copy link
Contributor

miraclx commented May 20, 2022

This is a tracking issue in resolution of the separation of jsonrpc-primitives from the rest of nearcore primitives.

This would help us maintain a stable API for JSON RPC, and simplify tracking changes.

Context:

Plan:

near-bulldozer bot pushed a commit that referenced this issue May 20, 2022
Tracking issue: #6850

Cleanup feature flags in `near-jsonrpc-adversarial-primitives`.
near-bulldozer bot pushed a commit that referenced this issue May 20, 2022
Tracking issue: #6850

Supercedes: #6849

Move request parsing logic from `jsonrpc-primitives` to the server.
nikurt pushed a commit that referenced this issue May 23, 2022
Tracking issue: #6850

Cleanup feature flags in `near-jsonrpc-adversarial-primitives`.
nikurt pushed a commit that referenced this issue May 23, 2022
Tracking issue: #6850

Supercedes: #6849

Move request parsing logic from `jsonrpc-primitives` to the server.
@frol frol mentioned this issue May 24, 2022
3 tasks
near-bulldozer bot pushed a commit that referenced this issue May 31, 2022
Tracking issue: #6850

Move all conversions between `near-primitives` and `near-jsonrpc-primitives` to the server side. Freeing up a bunch of dependencies on `near-jsonrpc-primitives`.
near-bulldozer bot pushed a commit that referenced this issue May 31, 2022
Tracking issue: #6850

Requires: #6902

Splits up the `parser` and `errors` module into finer and more specialized modules, consolidating both parsing and type conversion logic.
near-bulldozer bot pushed a commit that referenced this issue Aug 9, 2022
Stumbled on this as part of #6850

The only implementation of `BaseDecode` is for `CryptoHash` whose logic is no different from the implementation of `FromStr`.
nikurt pushed a commit that referenced this issue Aug 11, 2022
Stumbled on this as part of #6850

The only implementation of `BaseDecode` is for `CryptoHash` whose logic is no different from the implementation of `FromStr`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@miraclx and others