-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple jsonrpc-primitives
from near-primitives
#6850
Labels
Comments
This was referenced May 20, 2022
near-bulldozer bot
pushed a commit
that referenced
this issue
May 20, 2022
Tracking issue: #6850 Cleanup feature flags in `near-jsonrpc-adversarial-primitives`.
nikurt
pushed a commit
that referenced
this issue
May 23, 2022
Tracking issue: #6850 Cleanup feature flags in `near-jsonrpc-adversarial-primitives`.
nikurt
pushed a commit
that referenced
this issue
May 23, 2022
This was referenced May 27, 2022
near-bulldozer bot
pushed a commit
that referenced
this issue
May 31, 2022
Tracking issue: #6850 Move all conversions between `near-primitives` and `near-jsonrpc-primitives` to the server side. Freeing up a bunch of dependencies on `near-jsonrpc-primitives`.
This was referenced Jun 18, 2022
near-bulldozer bot
pushed a commit
that referenced
this issue
Aug 9, 2022
Stumbled on this as part of #6850 The only implementation of `BaseDecode` is for `CryptoHash` whose logic is no different from the implementation of `FromStr`.
nikurt
pushed a commit
that referenced
this issue
Aug 11, 2022
Stumbled on this as part of #6850 The only implementation of `BaseDecode` is for `CryptoHash` whose logic is no different from the implementation of `FromStr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a tracking issue in resolution of the separation of
jsonrpc-primitives
from the rest ofnearcore
primitives.This would help us maintain a stable API for JSON RPC, and simplify tracking changes.
Context:
jsonrpc
from rest of codebase, to preventrpc
s to breaking due to refactoring. #5516contract_compile
gas parameter #6587 (comment)Plan:
jsonrpc-primitives
into thenear-jsonrpc
server crate.nearcore
type conversions to server #6902parser
anderrors
module #6917nearcore
.Rpc*Request
resides inside each module.serde
requirement from, as many structures no longer need them onnearcore
.near-jsonrpc-primitives
crate to be as intuitive as can be.The text was updated successfully, but these errors were encountered: