Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jsonrpc): extract request parser #6849

Closed
wants to merge 1 commit into from
Closed

chore(jsonrpc): extract request parser #6849

wants to merge 1 commit into from

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented May 20, 2022 •
edited
Loading

Tracking issue: #6850

Step 1 in decoupling jsonrpc-primitives from the rest of nearcore.

Since we reuse the types both for the server and client, this introduces the server feature flag, for hiding things from the client API that's only needed for the server. The RpcRequest::parse method being one of it.

This also cleans up the jsonrpc-adversarial-primitives interface.

@miraclx miraclx requested a review from a team as a code owner May 20, 2022 13:38
@matklad matklad removed the request for review from jakmeier May 20, 2022 14:44
@miraclx
Copy link
Contributor Author

miraclx commented May 20, 2022 •
edited
Loading

I'm breaking this up.

@miraclx miraclx closed this May 20, 2022
@miraclx miraclx mentioned this pull request May 20, 2022
Merged
near-bulldozer bot pushed a commit that referenced this pull request May 20, 2022
@miraclx
chore(jsonrpc): move request parsing logic to server (#6853)
d18f345 
Tracking issue: #6850

Supercedes: #6849

Move request parsing logic from `jsonrpc-primitives` to the server.
nikurt pushed a commit that referenced this pull request May 23, 2022
@miraclx @nikurt
chore(jsonrpc): move request parsing logic to server (#6853)
4b5ab35 
Tracking issue: #6850

Supercedes: #6849

Move request parsing logic from `jsonrpc-primitives` to the server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khorolets khorolets khorolets approved these changes

@frol frol Awaiting requested review from frol

@matklad matklad Awaiting requested review from matklad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miraclx @khorolets