Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jsonrpc): split the parser and errors module #6917

Merged
merged 2 commits into from
May 31, 2022

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented May 30, 2022

Tracking issue: #6850

Requires: #6902

Splits up the parser and errors module into finer and more specialized modules, consolidating both parsing and type conversion logic.

@miraclx miraclx requested review from frol, matklad and khorolets May 30, 2022 19:49
@miraclx miraclx requested a review from a team as a code owner May 30, 2022 19:49
@miraclx miraclx force-pushed the decouple/jsonrpc/merge-parser-errors branch from 75bea64 to 6f4ef65 Compare May 30, 2022 19:50
@miraclx miraclx changed the title near_jsonrpc::{parser -> api::*} chore(jsonrpc): split the parser and errors module May 30, 2022
@miraclx miraclx force-pushed the decouple/jsonrpc/remove-actix branch from 671f70f to f516a37 Compare May 30, 2022 20:06
Base automatically changed from decouple/jsonrpc/remove-actix to master May 31, 2022 10:05
near-bulldozer bot pushed a commit that referenced this pull request May 31, 2022
Tagged: https://github.com/near/nearcore/releases/tag/crates-0.14.0

Notable changes:

  - #6844
  - #6853
  - #6902
  - #6917
  - #6916

Check here for a full changelog: crates-0.13.0...crates-0.14.0

Tested `cargo package` on each public crate locally, they all compile independently of the workspace. We should be good to go.
@miraclx miraclx force-pushed the decouple/jsonrpc/merge-parser-errors branch from cd41125 to 3a77a65 Compare May 31, 2022 14:09
@near-bulldozer near-bulldozer bot merged commit 7838182 into master May 31, 2022
@near-bulldozer near-bulldozer bot deleted the decouple/jsonrpc/merge-parser-errors branch May 31, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants