Multilingual prefLabels #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lang = nil | ||
| prefLabel = label | ||
| end | ||
| prefLabel = label if !prefLabel && lang === Goo.portal_language |
There was a problem hiding this comment.
can be simplified too
prefLabel ||= label if lang == Goo.portal_language
prefLabel ||= label
There was a problem hiding this comment.
and Goo.portal_language does not exist, it is Goo.main_languages.first.
There was a problem hiding this comment.
Goo.portal_language is a change that I implemented in GOO. I plan to create a PR for that shortly.
|
Good work, this will also fix in our side these issues: |
This was referenced Oct 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #220 +/- ##
===========================================
+ Coverage 78.82% 81.08% +2.25%
===========================================
Files 74 74
Lines 5375 5244 -131
===========================================
+ Hits 4237 4252 +15
+ Misses 1138 992 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mdorf
added a commit
to ncbo/ontologies_api
that referenced
this pull request
Oct 19, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the ability to annotate prefLabels with the language tag during the missing labels generation process