Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False EN prefLabel generated when there is no english label for a concept #515

Closed
jonquet opened this issue Apr 16, 2024 · 9 comments
Closed
Assignees
Labels
bug content Issues related to the content of AgroPortal enhancement

Comments

@jonquet
Copy link
Contributor

jonquet commented Apr 16, 2024

Go to:
https://agroportal.lirmm.fr/ontologies/AGROTERMOS?p=classes&conceptid=https%3A%2F%2Fsistemas.sede.embrapa.br%2Fagrotermos%2Fresources%2F2f7fc3250e134e16c53268ba949d79ec&language=all

Capture d’écran 2024-04-16 à 21 26 46

Whereas the source file does not contains this label.

Then this false label "take over" real one int he hierachy (when all languages is selected):
Capture d’écran 2024-04-16 à 21 29 36

@jonquet jonquet added enhancement content Issues related to the content of AgroPortal labels Apr 16, 2024
@jonquet

This comment was marked as duplicate.

@syphax-bouazzouni
Copy link
Contributor

At the parsing level, if we don't find for a concept a label in English or not tagged, we generate one, with no language tag(see the highlighted line in the screenshot below).

For the why we show here the generated label and not the portuguese one, in the "all languages" option. it is because Portuguese is not a priority, over the English or no-tagged values.

image

@jonquet
Copy link
Contributor Author

jonquet commented Apr 23, 2024

To be discussed again.
The behaviour is not really ok. Using the ID/notation as label is supposed to be a fall back in the UI but not a fallback in the backend (with a false triple generated) which then provoques a weird behaviour in the UI.

@jonquet
Copy link
Contributor Author

jonquet commented Apr 27, 2024

Note that with THESAGRO we see this behaviour (within the tree) is not consistent (random pick up a label):
Capture d’écran 2024-04-27 à 04 48 50

@syphax-bouazzouni
Copy link
Contributor

Is it fixed @jonquet, in Stageportal after the latest release, if we select Brazilian we get the label in that language and not our generated ones that are now explicitly tagged as English.
https://stageportal.lirmm.fr/ontologies/AGROTERMOS?p=classes&language=pt-br

@jonquet
Copy link
Contributor Author

jonquet commented Oct 29, 2024

Oui ce que tu decris est ok.
Par contre, je ne vois pas les labels autogénérés "explicitly tagged as English." => https://data.stageportal.lirmm.fr/ontologies/AGROTERMOS/classes/https%3A%2F%2Fsistemas.sede.embrapa.br%2Fagrotermos%2Fresources%2Fa6be24e7693ef30543e329dd3bc971a0?&display=all
et tant mieux d'ailleurs.
Et dans l'UI on a pas non plus les tag qui s'affiche pour ce faux label. Donc je pense que c'est mieux.

A noter que l'issue originale était a propos du comportement de générer automatiquement un label en EN si on en a pas (car c'est le language par défaut du portail). Et sur ca on avait dit qu'on avait pas trop le choix je crois me souvenir.

@syphax-bouazzouni
Copy link
Contributor

@jonquet bellow a screenshot showing the generated label
image
Before we didn't generate it
image

@jonquet
Copy link
Contributor Author

jonquet commented Oct 29, 2024

Ok merci de ces précisions. We are aligned.

If we consider we won't fix the fact that we generate "false labels" for the default portal language, then we could close this issue.
One thing remain : wen we select "All languanges" in the UI, the false non language-tagged label "takes over" one real label in another language.
See
https://stageportal.lirmm.fr/ontologies/AGROTERMOS?p=classes&language=all
Capture d’écran 2024-10-29 à 16 37 39

The question is: shall we pick up "another" label for which we have a language info.. in this case "Dicotiledónea"?

@syphax-bouazzouni
Copy link
Contributor

Ok merci de ces précisions. We are aligned.

If we consider we won't fix the fact that we generate "false labels" for the default portal language, then we could close this issue. One thing remain : wen we select "All languanges" in the UI, the false non language-tagged label "takes over" one real label in another language. See https://stageportal.lirmm.fr/ontologies/AGROTERMOS?p=classes&language=all Capture d’écran 2024-10-29 à 16 37 39

The question is: shall we pick up "another" label for which we have a language info.. in this case "Dicotiledónea"?

Done in ontoportal-lirmm/bioportal_web_ui#795 and ontoportal-lirmm/ontologies_linked_data#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug content Issues related to the content of AgroPortal enhancement
Projects
None yet
Development

No branches or pull requests

2 participants