Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue when generating multilingual missing labels #164

Merged

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Oct 24, 2024

@syphax-bouazzouni syphax-bouazzouni force-pushed the fix/multilingual-prefllabel-generation-error branch from be1c294 to 51cca3a Compare October 24, 2024 03:05
@syphax-bouazzouni syphax-bouazzouni changed the title fix the issue when generating multilingual missing labels Fix: issue when generating multilingual missing labels Oct 24, 2024
@syphax-bouazzouni syphax-bouazzouni self-assigned this Oct 24, 2024
@syphax-bouazzouni syphax-bouazzouni force-pushed the fix/multilingual-prefllabel-generation-error branch from 038cb5c to 1ac8d68 Compare October 24, 2024 03:55
@syphax-bouazzouni syphax-bouazzouni force-pushed the fix/multilingual-prefllabel-generation-error branch from 1ac8d68 to 09bc86f Compare October 24, 2024 04:31
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (337dce9) to head (09bc86f).
Report is 27 commits behind head on development.

Files with missing lines Patch % Lines
...on_process/operations/submission_missing_labels.rb 93.75% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #164      +/-   ##
===============================================
+ Coverage        81.31%   81.80%   +0.49%     
===============================================
  Files               89      102      +13     
  Lines             6512     6734     +222     
===============================================
+ Hits              5295     5509     +214     
- Misses            1217     1225       +8     
Flag Coverage Δ
unittests 81.80% <94.87%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant