Cherry-picks for 2.10.17-RC.4 #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… followers. Signed-off-by: Derek Collison <[email protected]>
…m sequence is consistent. (#5528) For a leader, it will skip msgs at the end to eof and remember o.sseq for the next getNextMsg call. But this will report stream delivered different for the leader vs the followers. Also if a consumer leader processed an ack ahead of delivered it would sync, but followers would not. This makes the behavior consistent between leaders and followers. Signed-off-by: Derek Collison <[email protected]> --------- Signed-off-by: Derek Collison <[email protected]>
Make these consistent from leaders and followers regardless of store type. Fixed a bug that would have followers stores inherit redelivered consumer delivered sequence which would break ack gap fill. Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
…eaving of state. With skipMsgs calling ProposeDirect, if the prop queue was not empty this would place the skip entry ahead of the other entries. This would result in sequence mismatch and stalled processing. Bug was we should not bypass the internal prop ipq for the nrg. This corrects it and renames to ProposeMulti. Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
…tries fblks. Signed-off-by: Derek Collison <[email protected]>
…rge number of messages. When we delete a consumer we need to simulate acking all messages from the ackfloor to the last sequence in the stream. If the consumer is new and only consumed and acked and few messages, or none, this could be costly and cause operational pauses for the parent stream. If the number of sequences we would need to process is obver a threshold we will let the checkInterestState() do the cleanup in a separate Go routine. Signed-off-by: Derek Collison <[email protected]>
…5548) For subjects `$JS`, `$JS.API`, `$JSC` and `$SYS` subjects, If NoAck is true they are now allowed, otherwise they will not be allowed. This allows proper setup of audit streams for production use cases. Signed-off-by: Derek Collison <[email protected]> --------- Signed-off-by: Derek Collison <[email protected]>
We often find ourselves without good visibility into what's really going on in the Raft layer. This endpoint dumps quite a substantial amount of internal Raft node state. Filters include: * `?acc=ACCNAME` to filter by account (defaults to system account if not specified) * `?group=GROUP` to show only specific groups Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
…ove restored stream. We did not remove it which could cause bad healthz reports on single servers for instance. Signed-off-by: Derek Collison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
/raftzmonitoring endpoint #5530 (BETA)The following PRs were NOT included as they were later reverted:
LoadNextMsgwith partial per-subject info state #5532Signed-off-by: Neil Twigg [email protected]