[FIXED] Make sure jsz reporting of filtered consumers delivered stream sequence is consistent. #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce is consistent. For a leader, it will skip msgs at the end to eof and remember o.sseq for the next getNextMsg call. But this will report stream delivered different for the leader vs the followers. Signed-off-by: Derek Collison <[email protected]>
…c, but followers would not. This makes the behavior consistent between leaders and followers. Signed-off-by: Derek Collison <[email protected]>
neilalexander
pushed a commit
that referenced
this pull request
Jun 17, 2024
…m sequence is consistent. (#5528) For a leader, it will skip msgs at the end to eof and remember o.sseq for the next getNextMsg call. But this will report stream delivered different for the leader vs the followers. Also if a consumer leader processed an ack ahead of delivered it would sync, but followers would not. This makes the behavior consistent between leaders and followers. Signed-off-by: Derek Collison <[email protected]> --------- Signed-off-by: Derek Collison <[email protected]>
wallyqs
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a leader, it will skip msgs at the end to eof and remember o.sseq for the next getNextMsg call.
But this will report stream delivered different for the leader vs the followers.
Also if a consumer leader processed an ack ahead of delivered it would sync, but followers would not.
This makes the behavior consistent between leaders and followers.
Signed-off-by: Derek Collison [email protected]