-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /raftz
monitoring endpoint
#5530
Conversation
This 2.11 correct? |
I didn't have a specific version in mind, whichever you think it's best. |
076e6b1
to
dfea05d
Compare
@neilalexander how expensive is this operation for all accounts? |
@@ -3006,6 +3007,8 @@ func (s *Server) startMonitoring(secure bool) error { | |||
mux.HandleFunc(s.basePath(HealthzPath), s.HandleHealthz) | |||
// IPQueuesz | |||
mux.HandleFunc(s.basePath(IPQueuesPath), s.HandleIPQueuesz) | |||
// Raftz | |||
mux.HandleFunc(s.basePath(RaftzPath), s.HandleRaftz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not making this available in the system account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason it can't be, just haven't done it yet. Don't know if it's better to keep it HTTP only until we're definitely happy with the shape of the request parameters & response.
@bruth The cost scales linearly with the number of HA assets but the PR is careful to only hold read locks for one Raft group at a time, so it shouldn't result in any global pauses. I could just make it default to |
Make $SYS only.. |
We often find ourselves without good visibility into what's really going on in the Raft layer. This endpoint dumps quite a substantial amount of internal Raft node state. Filters include: * `?acc=ACCNAME` to filter by account (defaults to system account if not specified) * `?group=GROUP` to show only specific groups Signed-off-by: Neil Twigg <[email protected]>
dfea05d
to
90fe702
Compare
Done, defaults to the system account now if no |
Sorry I might have mis-spoke, I assume this is only accessible via the system account, which is probably the case. And by default you gather all HAAsset data, but you can scope to only a certain accounts assets yes? |
At the moment it's only on the monitoring HTTP port and not accessible via For the filtering, previously if you didn't specify an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We often find ourselves without good visibility into what's really going on in the Raft layer. This endpoint dumps quite a substantial amount of internal Raft node state. Filters include: * `?acc=ACCNAME` to filter by account (defaults to system account if not specified) * `?group=GROUP` to show only specific groups Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
We often find ourselves without good visibility into what's really going on in the Raft layer. This endpoint dumps quite a substantial amount of internal Raft node state. Filters include: * `?acc=ACCNAME` to filter by account (defaults to system account if not specified) * `?group=GROUP` to show only specific groups Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
We often find ourselves without good visibility into what's really going on in the Raft layer. This endpoint dumps quite a substantial amount of internal Raft node state.
Filters include:
?acc=ACCNAME
to filter by account (defaults to system account if not specified)?group=GROUP
to show only specific groupsSigned-off-by: Neil Twigg [email protected]