Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Update dependencies #5538

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[IMPROVED] Update dependencies #5538

merged 1 commit into from
Jun 14, 2024

Conversation

derekcollison
Copy link
Member

Note that upgrading is fickle at the moment since go1.22 toolchain is not backward compatible. So if you upgrade using it the CI/CD tests for go1.21 would fail. So I did a manual backdrop to go1.21 in the go.mod and did not run go mod tidy.

Signed-off-by: Derek Collison [email protected]

@derekcollison
Update dependencies
14b9381 
Signed-off-by: Derek Collison <[email protected]>
@derekcollison derekcollison requested a review from a team as a code owner June 14, 2024 16:11
wallyqs
wallyqs approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs mentioned this pull request Jun 14, 2024
Closed
@neilalexander
Copy link
Member

I think you can do go mod tidy -go 1.21 if you want to pin it to an earlier Go version but still tidy.

@derekcollison
Copy link
Member Author

Ah cool! Thanks @neilalexander

@derekcollison derekcollison merged commit 445851c into main Jun 14, 2024
4 checks passed
@derekcollison derekcollison deleted the update-dependencies branch June 14, 2024 17:21
@neilalexander neilalexander mentioned this pull request Jun 17, 2024
Merged
wallyqs added a commit that referenced this pull request Jun 17, 2024
@wallyqs
Cherry-picks for 2.10.17-RC.4 (#5550)
e8d6600 
Includes the following:

* #5524
* #5528
* #5533
* #5535
* #5538
* #5543
* #5546
* #5545
* #5547
* #5548
* #5530 (**BETA**)
* #5549

The following PRs were **NOT** included as they were later reverted:

* #5532

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekcollison @neilalexander @wallyqs