Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log unhandled errors during license activation (no-changelog) #6165

Merged
merged 3 commits into from
May 3, 2023

Conversation

csuermann
Copy link
Contributor

No description provided.

@csuermann csuermann requested a review from netroy May 3, 2023 10:32
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@csuermann csuermann changed the title Fix: Log unhandled errors during license activation (no-changelog) fix: Log unhandled errors during license activation (no-changelog) May 3, 2023
netroy
netroy previously approved these changes May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.01 ⚠️

Comparison is base (8862e1e) 19.97% compared to head (486a2ea) 19.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6165      +/-   ##
==========================================
- Coverage   19.97%   19.97%   -0.01%     
==========================================
  Files        2621     2621              
  Lines      118062   118063       +1     
  Branches    18516    18518       +2     
==========================================
  Hits        23585    23585              
  Misses      93766    93766              
- Partials      711      712       +1     
Impacted Files Coverage Δ
packages/cli/src/license/license.controller.ts 80.35% <28.57%> (-1.13%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 97578c7 into master May 3, 2023
@netroy netroy deleted the fix-license-activation branch May 3, 2023 12:26
@janober
Copy link
Member

janober commented May 3, 2023

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request May 3, 2023
* master:
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  test: Address flaky setup e2e (no-changelog) (#6085)
  fix(core): Better errors for common status codes fix
  fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157)
  fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154)
  fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003)
  fix(core): Assign Unknown Error only if message or description not present in error
  fix(AWS S3 Node): Fix File upload, and add node tests (#6153)
  fix(core): Better error message in Webhook node when using the POST method
  feat(Microsoft Excel 365 Node): Overhaul
  fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
  ci: Restore load options methods validation (no-changelog) (#6148)
  feat(core): Add notice to alert users a new version is available
  fix(core): Fix canceled execution status (#6142)
  ci: Expand ESLint to tests in BE packages (no-changelog) (#6147)
  fix(editor): Fix focus jumping when using chrome autofill (#6140)
MiloradFilipovic added a commit that referenced this pull request May 3, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component:
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  test: Address flaky setup e2e (no-changelog) (#6085)
  fix(core): Better errors for common status codes fix
  fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157)
  fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154)
  fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003)
  fix(core): Assign Unknown Error only if message or description not present in error
  fix(AWS S3 Node): Fix File upload, and add node tests (#6153)
  fix(core): Better error message in Webhook node when using the POST method
  feat(Microsoft Excel 365 Node): Overhaul
  fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
  ci: Restore load options methods validation (no-changelog) (#6148)
  feat(core): Add notice to alert users a new version is available
  fix(core): Fix canceled execution status (#6142)
  ci: Expand ESLint to tests in BE packages (no-changelog) (#6147)
  fix(editor): Fix focus jumping when using chrome autofill (#6140)
MiloradFilipovic added a commit that referenced this pull request May 5, 2023
* master: (110 commits)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  feat(Kafka Trigger Node): Add non-parallel execution (#6175)
  fix(Postgres Node): Always return TIMESTAMP and TIMESTAMPZ as ISO string (#6145)
  fix: Revert change that hid the SSH private key (no-changelog) (#6158)
  fix(Google Sheets Node): Upgrade xlsx to address CVE-2023-30533 (#6172)
  fix(editor): Show the correct actions count in the nodes list (#6183)
  ci: Revert full db reset for e2e (no-changelog) (#6182)
  fix(AWS Rekognition Node): Fix all different action type (#6136)
  feat(Airtable Node): Access token support (#6160)
  fix(editor): Remove duplicate mapping of `item.json` key in data pinning (#6135)
  fix(HTTP Request Node): Correctly doesn't redirect on non GET method (#6132)
  fix(MySQL Node): Node should return date types as strings (#6169)
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  ...

# Conflicts:
#	packages/editor-ui/src/mixins/workflowHelpers.ts
#	packages/editor-ui/src/views/NodeView.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants