Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Update and fix storybook (was failing to run in local dev mode) #6180

Merged
merged 11 commits into from
May 4, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d381578) 20.06% compared to head (c05db54) 20.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6180   +/-   ##
=======================================
  Coverage   20.06%   20.06%           
=======================================
  Files        2622     2622           
  Lines      118083   118083           
  Branches    18556    18556           
=======================================
  Hits        23691    23691           
  Misses      93677    93677           
  Partials      715      715           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cstuncsik cstuncsik requested a review from netroy May 4, 2023 11:20
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

netroy
netroy previously approved these changes May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

netroy
netroy previously approved these changes May 4, 2023
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7th time is the charm

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik requested a review from netroy May 4, 2023 15:18
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 1e6a75f into master May 4, 2023
@netroy netroy deleted the n8n-6403-update-and-fix-storybook branch May 4, 2023 15:44
MiloradFilipovic added a commit that referenced this pull request May 5, 2023
* master: (110 commits)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  feat(Kafka Trigger Node): Add non-parallel execution (#6175)
  fix(Postgres Node): Always return TIMESTAMP and TIMESTAMPZ as ISO string (#6145)
  fix: Revert change that hid the SSH private key (no-changelog) (#6158)
  fix(Google Sheets Node): Upgrade xlsx to address CVE-2023-30533 (#6172)
  fix(editor): Show the correct actions count in the nodes list (#6183)
  ci: Revert full db reset for e2e (no-changelog) (#6182)
  fix(AWS Rekognition Node): Fix all different action type (#6136)
  feat(Airtable Node): Access token support (#6160)
  fix(editor): Remove duplicate mapping of `item.json` key in data pinning (#6135)
  fix(HTTP Request Node): Correctly doesn't redirect on non GET method (#6132)
  fix(MySQL Node): Node should return date types as strings (#6169)
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  ...

# Conflicts:
#	packages/editor-ui/src/mixins/workflowHelpers.ts
#	packages/editor-ui/src/views/NodeView.vue
MiloradFilipovic added a commit that referenced this pull request May 9, 2023
* master: (31 commits)
  feat(Date & Time Node): Overhaul of the node (#5904)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  feat(HubSpot Node): Overhaul the HubSpot Node (#4337)
  ci: Create a nightly v1 docker image (no-changelog) (#6197)
  refactor(core): Add deprecation notice for own mode (#6195)
  feat(core): Update config defaults for for v1 (no-changelog) (#6196)
  test(Read Binary Files Node): Unit tests (no-changelog) (#5459)
  refactor: Add deprecation notice for MySQL and MariaDB (#6189)
  test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666)
  fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193)
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  ...

# Conflicts:
#	packages/editor-ui/src/stores/nodeTypes.store.ts
#	packages/nodes-base/nodes/Postgres/Postgres.node.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts
MiloradFilipovic added a commit that referenced this pull request May 9, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component: (31 commits)
  feat(Date & Time Node): Overhaul of the node (#5904)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  feat(HubSpot Node): Overhaul the HubSpot Node (#4337)
  ci: Create a nightly v1 docker image (no-changelog) (#6197)
  refactor(core): Add deprecation notice for own mode (#6195)
  feat(core): Update config defaults for for v1 (no-changelog) (#6196)
  test(Read Binary Files Node): Unit tests (no-changelog) (#5459)
  refactor: Add deprecation notice for MySQL and MariaDB (#6189)
  test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666)
  fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193)
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  ...

# Conflicts:
#	packages/editor-ui/src/stores/nodeTypes.store.ts
@janober
Copy link
Member

janober commented May 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants