refactor: Add deprecation notice for MySQL and MariaDB #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6189 +/- ##
=======================================
Coverage 20.08% 20.08%
=======================================
Files 2626 2626
Lines 118218 118221 +3
Branches 18572 18573 +1
=======================================
+ Hits 23740 23741 +1
- Misses 93758 93760 +2
Partials 720 720
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
csuermann
reviewed
May 5, 2023
Co-authored-by: Cornelius Suermann <[email protected]>
csuermann
approved these changes
May 5, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 9, 2023
* master: (31 commits) feat(Date & Time Node): Overhaul of the node (#5904) refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194) refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194) feat(HubSpot Node): Overhaul the HubSpot Node (#4337) ci: Create a nightly v1 docker image (no-changelog) (#6197) refactor(core): Add deprecation notice for own mode (#6195) feat(core): Update config defaults for for v1 (no-changelog) (#6196) test(Read Binary Files Node): Unit tests (no-changelog) (#5459) refactor: Add deprecation notice for MySQL and MariaDB (#6189) test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666) fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193) fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170) ci: Fix test database cleanup (no-changelog) (#6188) refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254) refactor(editor): Add infix to Pinia stores (no-changelog) (#6149) ci: Fix linting issues on master (no-changelog) (#6186) fix(editor): Update and add design system checkbox component to Editor (#6178) fix(editor): Display SSO entry in Settings on Cloud (#6181) feat(Code Node): Add Python support (#4295) fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180) ... # Conflicts: # packages/editor-ui/src/stores/nodeTypes.store.ts # packages/nodes-base/nodes/Postgres/Postgres.node.ts # packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts
MiloradFilipovic
added a commit
that referenced
this pull request
May 9, 2023
…rce-mapper-ui-P2 * feature/resource-mapping-component: (31 commits) feat(Date & Time Node): Overhaul of the node (#5904) refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194) refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194) feat(HubSpot Node): Overhaul the HubSpot Node (#4337) ci: Create a nightly v1 docker image (no-changelog) (#6197) refactor(core): Add deprecation notice for own mode (#6195) feat(core): Update config defaults for for v1 (no-changelog) (#6196) test(Read Binary Files Node): Unit tests (no-changelog) (#5459) refactor: Add deprecation notice for MySQL and MariaDB (#6189) test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666) fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193) fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170) ci: Fix test database cleanup (no-changelog) (#6188) refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254) refactor(editor): Add infix to Pinia stores (no-changelog) (#6149) ci: Fix linting issues on master (no-changelog) (#6186) fix(editor): Update and add design system checkbox component to Editor (#6178) fix(editor): Display SSO entry in Settings on Cloud (#6181) feat(Code Node): Add Python support (#4295) fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180) ... # Conflicts: # packages/editor-ui/src/stores/nodeTypes.store.ts
|
Got released with |
|
Hey @luizeof It is being removed in 1.0 which will be available in a few weeks. SQLite will remain as the default option. You can find a list of the breaking 1.0 changes here: https://docs.n8n.io/1-0-preview/ |
|
Quick update: We decided not to remove support for MySQL / MariaDB in the upcoming version 1 just yet, but it is still advisable to switch to PostgreSQL or SQLite. |
To be sure, this is about the storage of n8n itself and not about the mysql node? |
|
@Soetens you got it 👍 this is just for the backend and not the node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):