Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Restore load options methods validation (no-changelog) #6148

Merged
merged 2 commits into from
May 2, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 2, 2023

Removed here because of the issue later fixed by #6014.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (839a56a) 19.42% compared to head (327a489) 19.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6148   +/-   ##
=======================================
  Coverage   19.42%   19.42%           
=======================================
  Files        2590     2590           
  Lines      117112   117112           
  Branches    18389    18389           
=======================================
  Hits        22747    22747           
  Misses      93700    93700           
  Partials      665      665           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

agobrech
agobrech previously approved these changes May 2, 2023
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit d9af691 into master May 2, 2023
@ivov ivov deleted the restore-load-options-methods-validation branch May 2, 2023 09:19
@janober
Copy link
Member

janober commented May 3, 2023

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request May 3, 2023
* master:
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  test: Address flaky setup e2e (no-changelog) (#6085)
  fix(core): Better errors for common status codes fix
  fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157)
  fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154)
  fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003)
  fix(core): Assign Unknown Error only if message or description not present in error
  fix(AWS S3 Node): Fix File upload, and add node tests (#6153)
  fix(core): Better error message in Webhook node when using the POST method
  feat(Microsoft Excel 365 Node): Overhaul
  fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
  ci: Restore load options methods validation (no-changelog) (#6148)
  feat(core): Add notice to alert users a new version is available
  fix(core): Fix canceled execution status (#6142)
  ci: Expand ESLint to tests in BE packages (no-changelog) (#6147)
  fix(editor): Fix focus jumping when using chrome autofill (#6140)
MiloradFilipovic added a commit that referenced this pull request May 3, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component:
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  test: Address flaky setup e2e (no-changelog) (#6085)
  fix(core): Better errors for common status codes fix
  fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157)
  fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154)
  fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003)
  fix(core): Assign Unknown Error only if message or description not present in error
  fix(AWS S3 Node): Fix File upload, and add node tests (#6153)
  fix(core): Better error message in Webhook node when using the POST method
  feat(Microsoft Excel 365 Node): Overhaul
  fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
  ci: Restore load options methods validation (no-changelog) (#6148)
  feat(core): Add notice to alert users a new version is available
  fix(core): Fix canceled execution status (#6142)
  ci: Expand ESLint to tests in BE packages (no-changelog) (#6147)
  fix(editor): Fix focus jumping when using chrome autofill (#6140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants