fix(AWS S3 Node): Fix File upload, and add node tests #6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6153 +/- ##
==========================================
+ Coverage 19.42% 19.92% +0.50%
==========================================
Files 2591 2621 +30
Lines 117121 118030 +909
Branches 18389 18501 +112
==========================================
+ Hits 22750 23521 +771
- Misses 93706 93804 +98
- Partials 665 705 +40
☔ View full report in Codecov by Sentry. |
agobrech
approved these changes
May 2, 2023
|
✅ All Cypress E2E specs passed |
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
May 3, 2023
* master: feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171) 🚀 Release 0.227.0 (#6167) fix(editor): Flag issues only on workflow activation (#6127) fix(editor): Faster reconnects for push (no-changelog) (#6164) fix: Log unhandled errors during license activation (no-changelog) (#6165) test: Address flaky setup e2e (no-changelog) (#6085) fix(core): Better errors for common status codes fix fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157) fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154) fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003) fix(core): Assign Unknown Error only if message or description not present in error fix(AWS S3 Node): Fix File upload, and add node tests (#6153) fix(core): Better error message in Webhook node when using the POST method feat(Microsoft Excel 365 Node): Overhaul fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143) ci: Restore load options methods validation (no-changelog) (#6148) feat(core): Add notice to alert users a new version is available fix(core): Fix canceled execution status (#6142) ci: Expand ESLint to tests in BE packages (no-changelog) (#6147) fix(editor): Fix focus jumping when using chrome autofill (#6140)
MiloradFilipovic
added a commit
that referenced
this pull request
May 3, 2023
…rce-mapper-ui-P2 * feature/resource-mapping-component: feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171) 🚀 Release 0.227.0 (#6167) fix(editor): Flag issues only on workflow activation (#6127) fix(editor): Faster reconnects for push (no-changelog) (#6164) fix: Log unhandled errors during license activation (no-changelog) (#6165) test: Address flaky setup e2e (no-changelog) (#6085) fix(core): Better errors for common status codes fix fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157) fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154) fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003) fix(core): Assign Unknown Error only if message or description not present in error fix(AWS S3 Node): Fix File upload, and add node tests (#6153) fix(core): Better error message in Webhook node when using the POST method feat(Microsoft Excel 365 Node): Overhaul fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143) ci: Restore load options methods validation (no-changelog) (#6148) feat(core): Add notice to alert users a new version is available fix(core): Fix canceled execution status (#6142) ci: Expand ESLint to tests in BE packages (no-changelog) (#6147) fix(editor): Fix focus jumping when using chrome autofill (#6140)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 file uploads broke since #6131 because of this check being incorrect.
This PR also updates the node testing framework to start using credentials classes as well.