Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Notion Node): Add option to update icon when updating a page #5670

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

romeobalta
Copy link
Contributor

@romeobalta romeobalta commented Mar 10, 2023

Github issue / Community forum post (link here to close automatically): N/A

Screenshots:

Screenshot 2023-03-10 at 13 11 08

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2023

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Mar 10, 2023
@Joffcom
Copy link
Member

Joffcom commented May 18, 2023

NODE-547

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label May 18, 2023
@Joffcom
Copy link
Member

Joffcom commented Jul 4, 2023

Hey @romeobalta,

Thanks for the PR, It looks good to me so I have approved it and will try to get it merged in time for the next release.

@Joffcom Joffcom changed the title feat(Notion Node): add option to update icon when updating a page feat(Notion Node): Add option to update icon when updating a page Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (3ca66be) 28.89% compared to head (97713c6) 28.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5670      +/-   ##
==========================================
- Coverage   28.89%   28.84%   -0.05%     
==========================================
  Files        3068     3070       +2     
  Lines      188294   188247      -47     
  Branches    20895    20876      -19     
==========================================
- Hits        54404    54300     -104     
- Misses     133006   133063      +57     
  Partials      884      884              
Impacted Files Coverage Δ
...nodes-base/nodes/Notion/DatabasePageDescription.ts 0.00% <ø> (ø)
...ckages/nodes-base/nodes/Notion/v2/NotionV2.node.ts 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joffcom Joffcom merged commit 225e849 into n8n-io:master Jul 4, 2023
MiloradFilipovic added a commit that referenced this pull request Jul 5, 2023
* master:
  fix(core): Remove typeorm patches, but still enforce transactions on every migration (#6594)
  feat(Strava Node): Add hide_from_home field in Activity Update (#5883)
  feat(Notion Node): Add option to update icon when updating a page (#5670)
  refactor: Setup node context API, and consolidate code between Webhook and Wait nodes (no-changelog) (#6464)
  fix(core): Fix migrations for MySQL/MariaDB (#6591)
  fix(editor): Show retry information in execution list only when it exists (#6587)
  fix(Strapi Node): Fix issue with pagination (#4991)
  refactor(Item Lists Node): Refactoring (#6575)
  feat: Add crowd.dev node and trigger node (#6082)
  ci: Add Github Action to enforce template to issues (#5295)
  fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572)
  fix(Brevo Node): Rename SendInBlue node to Brevo node (#6521)
  fix(XML Node): Fix issue with not returning valid data (#6565)
  feat(HTTP Request Node): New http request generic custom auth credential (#5798)
  fix(core): Fix credentials test (#6569)
  fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563)
  docs: Add irreversible change warning for [email protected] (no-changelog) (#6558)
  feat: Add various source control improvements (#6533)
  feat(Twitter Node): Node overhaul (#4788)
This was referenced Jul 5, 2023
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants