Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump aegir from 22.1.0 to 25.0.0 #131

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 22, 2020

Bumps aegir from 22.1.0 to 25.0.0.

Release notes

Sourced from aegir's releases.

v25.0.0

Bug Fixes

  • remove docsFormats from release cmd (39e44b0)
  • use bugfixes: true in the babel config (2fc9878)

Features

v24.0.0

Features

  • default to not include node globals anf builtins (#578) (fecb4ae)

BREAKING CHANGES

  • browser code will NOT have node globals and builtins available.

v23.0.0

Bug Fixes

Features

  • clean up deps, utils, release cmd and docs (#581) (4b4ce35)

BREAKING CHANGES

  • remove karma-edge and remove docsFormats from docs cmd
  • Flow support was removed
Changelog

Sourced from aegir's changelog.

25.0.0 (2020-06-20)

Bug Fixes

  • remove docsFormats from release cmd (39e44b0)
  • use bugfixes: true in the babel config (2fc9878)

Features

24.0.0 (2020-06-16)

Features

  • default to not include node globals anf builtins (#578) (fecb4ae)

BREAKING CHANGES

  • browser code will NOT have node globals and builtins available.

23.0.0 (2020-06-12)

Bug Fixes

Features

  • clean up deps, utils, release cmd and docs (#581) (4b4ce35)

BREAKING CHANGES

  • remove karma-edge and remove docsFormats from docs cmd
  • Flow support was removed
Commits
  • 2fe4403 chore: release version v25.0.0
  • ff05684 chore: update contributors
  • 39e44b0 fix: remove docsFormats from release cmd
  • 9dc23a3 feat: support ts(#584)
  • ff0ea7f docs: add github actions wiki link
  • 2fc9878 fix: use bugfixes: true in the babel config
  • ccfc1c9 chore: update deps
  • e52ec6a chore: release version v24.0.0
  • 7434920 chore: update contributors
  • fecb4ae feat: default to not include node globals anf builtins (#578)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/aegir-25.0.0 branch from fa44133 to 550fa1e Compare August 7, 2020 15:01
@achingbrain
Copy link
Member

The test/types.spec.ts file added in #112 appears to be breaking the aegir upgrade.

Recent versions of aegir have become ts-aware so maybe something needs configuring or moving around.

@robertkiel @carsonfarmer @wemeetagain @Gozala any ideas on a good way to fix it?

@Gozala
Copy link
Contributor

Gozala commented Aug 7, 2020

The test/types.spec.ts file added in #112 appears to be breaking the aegir upgrade.

Recent versions of aegir have become ts-aware so maybe something needs configuring or moving around.

From what I can tell it's jslint complaining about import

import Multiaddr from "../src";

Seem like aegir should relax it's lint rules for .ts files. I'll see if I can find a place to do that.

@Gozala
Copy link
Contributor

Gozala commented Aug 7, 2020

Looking at aegir it seems that it attempt to use either TS or JS lint rules

https://github.com/ipfs/aegir/blob/2fe4403f19cb9cbf51560b31aa659fb90fded18c/src/lint.js#L86

And problem here is that it chooses to apply JS rules, but also do so on TS files.

@Gozala
Copy link
Contributor

Gozala commented Aug 7, 2020

@achingbrain I have created #141 to unblock the aegir update. However it ends up working around two problems in new aegir ipfs/aegir#618, ipfs/aegir#619

* fix: disable linter for types/types.spec.ts

* fix: use custom eslintrc instead

* fix: lint errors

* chore: enable ts support for tests

* fix: workaround ipfs/aegir#619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/dependencies Topic dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants