chore: release script workaround typescript fail #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's manually run releases without tests instead of changing the default here so we don't end up forgetting to change this back once it's fixed in aegir |
achingbrain
deleted the
chore/release-script-workaround-typescript-fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the aegir updated on #131 the test script got broken. It was temporarily fixed by adding
--tsas followsaegir test --ts -t nodefor Node.js tests. The browser tests fail if they have the same option as described on ipfs/aegir#619 .As a result of this issue, the release script is also failing. I tried to add the
--tsoption for the release but it fails within the browser tests scope. I added the skip tests option to the release and trigger the tests on theprereleasescript while we do not fix the underlying issue